Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Observability AI Assistant] Refactor ObservabilityAIAssistantClient #180633

Closed
dgieselaar opened this issue Apr 11, 2024 · 1 comment
Closed

[Observability AI Assistant] Refactor ObservabilityAIAssistantClient #180633

dgieselaar opened this issue Apr 11, 2024 · 1 comment
Assignees
@dgieselaar
Labels
Team:Obs AI Assistant Observability AI Assistant technical debt Improvement of the software architecture and operational architecture
Milestone
8.15

Comments

@dgieselaar
Copy link
Member

The ObservabilityAIAssistantClient is starting to get a little unwieldy. We should consider refactoring it.

  • Improve readability of complete - it is currently hard to follow, uses promises and observables interchangeably, some things are quite deeply nested, etc.
  • The tests for the client are all in a single file. Every test has a sizable amount of boiler plate, and we are also testing streams with it. We should split that up and see if we can reduce the amount of boiler plate.
@dgieselaar dgieselaar added the technical debt Improvement of the software architecture and operational architecture label Apr 11, 2024
@botelastic botelastic bot added the needs-team Issues missing a team label label Apr 11, 2024
@dgieselaar dgieselaar added the Team:Obs AI Assistant Observability AI Assistant label Apr 11, 2024
@botelastic botelastic bot removed the needs-team Issues missing a team label label Apr 11, 2024
@miltonhultgren
Copy link
Contributor

Would be good to also make the tests not depend on the timing for which promise resolves first (title or the next response after user instructions are resolved).

@emma-raffenne emma-raffenne added this to the 8.15 milestone Apr 17, 2024
@dgieselaar dgieselaar mentioned this issue Apr 18, 2024
Merged
@dgieselaar dgieselaar self-assigned this Apr 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dgieselaar dgieselaar

Labels
Team:Obs AI Assistant Observability AI Assistant technical debt Improvement of the software architecture and operational architecture
Projects
None yet
Milestone
8.15
Development

No branches or pull requests
3 participants
@dgieselaar @miltonhultgren @emma-raffenne