Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup: remove all the module.exports #18003

Closed
elasticmachine opened this issue May 31, 2017 · 3 comments
Closed

Cleanup: remove all the module.exports #18003

elasticmachine opened this issue May 31, 2017 · 3 comments
Labels
Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc test

Comments

@elasticmachine
Copy link
Contributor

Original comment by @tsullivan:

LINK REDACTED

After LINK REDACTED we'll have suppressed import/default warnings due to a lot of files still using module.exports. In some cases, this is necessary - for example: webShims and gulp_helpers. We'll have to add a comment to disable warning about those cases. In other places, for example: plugins/graph/public/graphClientWorkspace.js, we need to replace with export syntax.

Related to #12084

@elasticmachine
Copy link
Contributor Author

Original comment by @w33ble:

Just a note, the export transform in LINK REDACTED will do most of the heavy lifting here. You just need to review the output and make tweaks at that point. That's how I created the PR in Kibana.

@elasticmachine
Copy link
Contributor Author

Original comment by @tsullivan:

Much of this also waits on #12084

@timroes timroes added the Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc label Aug 17, 2018
@tsullivan
Copy link
Member

This has been implemented

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc test
Projects
None yet
Development

No branches or pull requests

3 participants