Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Detection Engine][FTR] Unskip alerts migration test #179593

Open
yctercero opened this issue Mar 28, 2024 · 1 comment
Open

[Detection Engine][FTR] Unskip alerts migration test #179593

yctercero opened this issue Mar 28, 2024 · 1 comment
Labels
impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. skipped-test Team:Detection Engine Security Solution Detection Engine Area

Comments

@yctercero
Copy link
Contributor

Tracking skipped test - https://github.com/elastic/kibana/blob/v8.13.0/x-pack/test/security_solution_api_integration/test_suites/detections_response/detection_engine/alerts/trial_license_complete_tier/migrations/finalize_alerts_migrations.ts#L193

Per Ryland's comment:

[...] it's been skipped since #85690. I don't recall exactly why it was skipped, and it doesn't look like I left any clues for us 😢 .

However, I was surprised to see the build was green after unskipping this. It looks to be a false positive, as the actual assertions of this test are commented out below (and most obviously, no getMigration helper currently exists).

We'll need to determine whether to unskip or delete.

@yctercero yctercero added skipped-test impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. Team:Detection Engine Security Solution Detection Engine Area labels Mar 28, 2024
@elasticmachine
Copy link
Contributor

Pinging @elastic/security-detection-engine (Team:Detection Engine)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. skipped-test Team:Detection Engine Security Solution Detection Engine Area
Projects
None yet
Development

No branches or pull requests

2 participants