Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Security Solution]no spacing in "Saved x time ago" on timeline #173350

Closed
ghost opened this issue Dec 14, 2023 · 7 comments
Closed

[Security Solution]no spacing in "Saved x time ago" on timeline #173350

ghost opened this issue Dec 14, 2023 · 7 comments
Assignees
Labels
bug Fixes for quality problems that affect the customer experience fixed impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. QA:Validated Issue has been validated by QA Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. Team:Threat Hunting:Investigations Security Solution Investigations Team Team:Threat Hunting Security Solution Threat Hunting Team v8.12.0

Comments

@ghost
Copy link

ghost commented Dec 14, 2023

Describe the bug:
no spacing in "Saved x time ago" on timeline

Kibana/Elasticsearch Stack version
Version: 8.12.0
Commit:93cff0aacd70bd0835cd244348f742ba3cafc4aa
Build: 69840

Browser and Browser OS Version:
Firefox for windows OS
Version: 120.0.1

Elastic Endpoint Version:
N/A

Original install method:
None

Functional Area:
Alert Table

Initial Setup:

  • None

precondition

  • N/A

Steps to reproduce

  • Create a timeline and save it
  • Observed in the message of Saved2mintues ago there should be space after the saved word

Additional Result

  • N/A

Current Result

  • no spacing in "Saved x time ago" on timeline

Expected behavior:

  • Spacing after the word saved in timeline save time history

image

Screen-Shot:

image

image

@ghost ghost added bug Fixes for quality problems that affect the customer experience triage_needed Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. labels Dec 14, 2023
@elasticmachine
Copy link
Contributor

Pinging @elastic/security-solution (Team: SecuritySolution)

@ghost ghost added impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. Team:Threat Hunting:Investigations Security Solution Investigations Team v8.12.0 labels Dec 14, 2023
@ghost ghost assigned MadameSheema Dec 14, 2023
@MadameSheema MadameSheema added the Team:Threat Hunting Security Solution Threat Hunting Team label Dec 14, 2023
@elasticmachine
Copy link
Contributor

Pinging @elastic/security-threat-hunting (Team:Threat Hunting)

@logeekal
Copy link
Contributor

This is already fixed and should be available in next BC.

@logeekal logeekal added the fixed label Dec 19, 2023
@ghost
Copy link
Author

ghost commented Jan 11, 2024

@logeekal we have observed that saved x timestamp message is not showing along side the timeline title .

Build Details:

Version: 8.12.0
Commit: e9092c0a17923f4ed984456b8a5db619b0a794b3
Build: 70088

so could you please confirm this change of stop showing the save timestamp message along the timeline title ?

Before

290443095-721ad84f-7653-4810-a8d2-ec4fa1721d19

BC6

image

c.c @MadameSheema

@MadameSheema
Copy link
Member

@michaelolo24 @PhilippeOberti can you please check the above message and confirm? Thanks! :)

@PhilippeOberti
Copy link
Contributor

if I'm not mistaken, these lines of code are what was displaying the Saved xx in the UI. The code was removed in this PR merged back in mid December and backported to 8.12 via this backport PR.
I want to say that the change was intentional, though there is no mention in the PR description. @logeekal or @michaelolo24 will confirm!

@ghost
Copy link
Author

ghost commented Feb 15, 2024

Hi @MadameSheema

Hi @e40pud

we have validated this issue on main branch and below are observation.

Current Status: Fixed ✔️
Build : Mains
Remark: No more longer display of Saved xx along the timeline title

Screen-Shot

image

c.c @MadameSheema

@ghost ghost closed this as completed Feb 15, 2024
@ghost ghost added the QA:Validated Issue has been validated by QA label Feb 15, 2024
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Fixes for quality problems that affect the customer experience fixed impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. QA:Validated Issue has been validated by QA Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. Team:Threat Hunting:Investigations Security Solution Investigations Team Team:Threat Hunting Security Solution Threat Hunting Team v8.12.0
Projects
None yet
Development

No branches or pull requests

5 participants