Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Links] Unable to view by-reference links panels if user does not have saved object management permissions #173305

Closed
Heenawter opened this issue Dec 13, 2023 · 1 comment · Fixed by #173332
Assignees
Labels
bug Fixes for quality problems that affect the customer experience impact:high Addressing this issue will have a high level of impact on the quality/strength of our product. loe:small Small Level of Effort Project:Dashboard Navigation Related to the Dashboard Navigation Project Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas

Comments

@Heenawter
Copy link
Contributor

Heenawter commented Dec 13, 2023

Tip

This was reported here: #166896 (comment)

Describe the bug:

When a user does not have Saved Objects Management permissions in their role, they are unable to see by-reference links panels and simply see the following "Forbidden" error:

image

Looking into this, and it seems to fail at the point we try to fetch the Links saved object from the content management client in the unwrapMethod from src/plugins/links/public/services/attribute_service.ts. Fetching other saved objects (visualizations, dashboards, etc.) do not fail, so I wonder if we have to add something to the Links CM type that will allow this? 🤔

Steps to reproduce:

  1. Create a dashboard with one by-reference links panel and another by-value.
  2. Create a role without Saved Objects Management permissions.
  3. Create a user and assign that role to them.
  4. Login to Kibana with this new user.
  5. Open the Dashboard from step 1.
  6. The by-reference links panel will fail to load 🔥 But the by-value links panel will load fine! 🎉

Note

Note that other by reference panels load just fine without this permission.

Expected behavior:
Links panels should be fetchable without Saved Objects Management permissions, just like other by-reference panels.

@Heenawter Heenawter added bug Fixes for quality problems that affect the customer experience Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas loe:medium Medium Level of Effort impact:high Addressing this issue will have a high level of impact on the quality/strength of our product. Project:Dashboard Navigation Related to the Dashboard Navigation Project labels Dec 13, 2023
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-presentation (Team:Presentation)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Fixes for quality problems that affect the customer experience impact:high Addressing this issue will have a high level of impact on the quality/strength of our product. loe:small Small Level of Effort Project:Dashboard Navigation Related to the Dashboard Navigation Project Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants