Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[UnifiedDataTable] Add display option to hide / show field token in header cells #173155

Closed
Tracked by #168084 ...
kertal opened this issue Dec 12, 2023 · 4 comments
Closed
Tracked by #168084 ...
Labels
enhancement New value added to drive a business result Feature:Discover Discover Application Feature:UnifiedDataTable Icebox impact:medium Addressing this issue will have a medium level of impact on the quality/strength of our product. loe:medium Medium Level of Effort Team:DataDiscovery Discover, search (e.g. data plugin and KQL), data views, saved searches. For ES|QL, use Team:ES|QL.

Comments

@kertal
Copy link
Member

kertal commented Dec 12, 2023

In #167179 we introduced field tokens to the UnifiedDataTable grid header. Now we should make it configureable, to optimize for use cases there this additional information is redundant.

  • In UI by adding a new configuration toggle to the Display options
  • On component level, allowing consumers to set the default value

Discover_-_Elastic

If we are able to move forward with adding tokens to the Document column, this configuration can also be used for this:
#164634

Open question

  • We need to clarify, if this setting needs to be persisted in saved search in Discover, like all other settings in the Display options popover, or should it persisted e.g. in Browser localStorage
@botelastic botelastic bot added the needs-team Issues missing a team label label Dec 12, 2023
@kertal kertal added Team:DataDiscovery Discover, search (e.g. data plugin and KQL), data views, saved searches. For ES|QL, use Team:ES|QL. and removed needs-team Issues missing a team label labels Dec 12, 2023
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-data-discovery (Team:DataDiscovery)

@kertal kertal added enhancement New value added to drive a business result Feature:Discover Discover Application impact:medium Addressing this issue will have a medium level of impact on the quality/strength of our product. loe:small Small Level of Effort labels Dec 12, 2023
@kertal kertal added loe:medium Medium Level of Effort and removed loe:small Small Level of Effort labels Feb 14, 2024
@MichaelMarcialis
Copy link
Contributor

MichaelMarcialis commented Jul 22, 2024

We need to clarify, if this setting needs to be persisted in saved search in Discover, like all other settings in the Display options popover, or should it persisted e.g. in Browser localStorage

@kertal: That's a tricky one. On one hand, it would be nice to have all preferences within that popover be consistent in how they are implemented and persisted. As such, including it as part of the saved object would make sense for that consistency.

On the other hand, while items like column width, row height, and sample size make sense to persist at the saved object level (and showing for all users), other more subjective preferences like toggling row stripes and field type tokens might be better suited as an assistive option for individual users and persisted across all Discover sessions for that particular user (and not showing for those that don't want them).

I suppose for now, my recommendation would be to stick with the consistent approach, and re-evaluate if we get user feedback to the contrary. CCing @andreadelrio as well, in case she has thoughts.

@kertal
Copy link
Member Author

kertal commented Jul 23, 2024

I suppose for now, my recommendation would be to stick with the consistent approach, and re-evaluate if we get user feedback to the contrary. CCing @andreadelrio as well, in case she has thoughts.

thx for your feeback. this approach matches very well with what we discussed in our team sync. I'd suggest to icebox this, and to unfreeze when needed

@kertal
Copy link
Member Author

kertal commented Oct 21, 2024

Closing this because it's not planned to be resolved in the foreseeable future. It will be tracked in our Icebox and will be re-opened if our priorities change. Feel free to re-open if you think it should be melted sooner.

@kertal kertal closed this as not planned Won't fix, can't repro, duplicate, stale Oct 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New value added to drive a business result Feature:Discover Discover Application Feature:UnifiedDataTable Icebox impact:medium Addressing this issue will have a medium level of impact on the quality/strength of our product. loe:medium Medium Level of Effort Team:DataDiscovery Discover, search (e.g. data plugin and KQL), data views, saved searches. For ES|QL, use Team:ES|QL.
Projects
None yet
Development

No branches or pull requests

3 participants