Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Isolated point styles override user defined point styles in timelion #172995

Closed
nickofthyme opened this issue Dec 8, 2023 · 3 comments
Closed
Assignees
Labels
blocked bug Fixes for quality problems that affect the customer experience Feature:ElasticCharts Issues related to the elastic-charts library Feature:Timelion Timelion app and visualization impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. regression Team:Visualizations Visualization editors, elastic-charts and infrastructure

Comments

@nickofthyme
Copy link
Contributor

nickofthyme commented Dec 8, 2023

Kibana version:

Added in v8.9.0 via #159082

Describe the bug:

In timelion and any app/vis that uses @elastic/charts, when you have sparse data that has isolated points (a finite point between two infinite points such as null) and you override the areaSeriesStyle or lineSeriesStyle on a chart, the isolatedPoint styles take precedence without merging with the defined point styles.

Steps to reproduce:

  1. Download the kibana sample data logs
  2. Create a timelion vis using this expression...
.es(index=kibana_sample_data_logs,metric=sum:bytes,),
.es(index=kibana_sample_data_logs,metric=sum:bytes)
    .if(operator=gt, if=100000, then=.es(index=kibana_sample_data_logs,metric=sum:bytes), null)
    .points(radius=5)
  1. Set the time picker the last 7 days
  2. Notice some of the points are small while most are big (i.e. 5px radius).

Expected behavior:

Isolated point styles are merged with point style defaults.

Screenshots (if relevant):

TestingTL - Elastic 2023-12-08 at 1 13 47 PM

Any additional context:

Elastic charts issue here 👉🏼 elastic/elastic-charts#2277

@nickofthyme nickofthyme added bug Fixes for quality problems that affect the customer experience Feature:Timelion Timelion app and visualization Feature:ElasticCharts Issues related to the elastic-charts library labels Dec 8, 2023
@nickofthyme nickofthyme self-assigned this Dec 8, 2023
@botelastic botelastic bot added the needs-team Issues missing a team label label Dec 8, 2023
@nickofthyme nickofthyme added the Team:Visualizations Visualization editors, elastic-charts and infrastructure label Dec 8, 2023
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-visualizations (Team:Visualizations)

@botelastic botelastic bot removed the needs-team Issues missing a team label label Dec 8, 2023
@stratoula stratoula added the impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. label Jan 24, 2024
@stratoula
Copy link
Contributor

Thank you for contributing to this issue, however, we are closing this issue due to inactivity as part of a backlog grooming effort. If you believe this feature/bug should still be considered, please reopen with a comment.

@nickofthyme
Copy link
Contributor Author

This will actually be fixed when elastic charts is updated to include elastic/elastic-charts#2277

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
blocked bug Fixes for quality problems that affect the customer experience Feature:ElasticCharts Issues related to the elastic-charts library Feature:Timelion Timelion app and visualization impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. regression Team:Visualizations Visualization editors, elastic-charts and infrastructure
Projects
None yet
Development

No branches or pull requests

3 participants