Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SLO] Editing an SLO without view_index_metadata on source leaves the SLO in a broken state. #168051

Closed
simianhacker opened this issue Oct 4, 2023 · 2 comments · Fixed by #168142
Assignees
Labels
bug Fixes for quality problems that affect the customer experience Feature:SLO Team: Actionable Observability - DEPRECATED For Observability Alerting and SLOs use "Team:obs-ux-management", for AIops "Team:obs-knowledge"

Comments

@simianhacker
Copy link
Member

Kibana version:

main

Original install method (e.g. download page, yum, from source, etc.):

source

Describe the bug:

When a user, withoutview_index_metadata on the source data, edits an SLO, the transform fails to update and leaves the SLO in a broken state. The SLO saved object definition is updated but the summary, roll-up data, and transform are all deleted.

Steps to reproduce:

Start with a fresh Kibana instance and index data from High Cardinality's fake_stack data

  1. Create an SLO with a superuser account, use the elastic user on dev.
  2. Create a role that has: the manage_transforms cluster privileges; all on .slo-* index pattern; read on high-* index pattern.
  3. Create a user with the role from step 2
  4. Login as that user
  5. Edit the SLO created in step 1
  6. You will end up on the SLO welcome screen without an SLOs listed. The "summary" and "roll-up" indices will be empty, the transform will be missing, and the SLO definition will exist in the saved objects index.

Expected behavior:

We should disable the edit screen when a user doesn't have sufficient privileges on transforms and the source data.

@simianhacker simianhacker added bug Fixes for quality problems that affect the customer experience Feature:SLO labels Oct 4, 2023
@botelastic botelastic bot added the needs-team Issues missing a team label label Oct 4, 2023
@simianhacker simianhacker added the Team: Actionable Observability - DEPRECATED For Observability Alerting and SLOs use "Team:obs-ux-management", for AIops "Team:obs-knowledge" label Oct 4, 2023
@elasticmachine
Copy link
Contributor

Pinging @elastic/actionable-observability (Team: Actionable Observability)

@botelastic botelastic bot removed the needs-team Issues missing a team label label Oct 4, 2023
@kdelemme
Copy link
Contributor

kdelemme commented Oct 5, 2023

Related to #167938

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Fixes for quality problems that affect the customer experience Feature:SLO Team: Actionable Observability - DEPRECATED For Observability Alerting and SLOs use "Team:obs-ux-management", for AIops "Team:obs-knowledge"
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants