Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Event annotations] [TableListView] Visualize library annotation group tab enhancements #166738

Open
MichaelMarcialis opened this issue Sep 19, 2023 · 4 comments
Assignees
Labels
Component:TableListView enhancement New value added to drive a business result Feature:Content Management User generated content (saved objects) management Feature:Lens impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. Team:SharedUX Team label for AppEx-SharedUX (formerly Global Experience) Team:Visualizations Visualization editors, elastic-charts and infrastructure

Comments

@MichaelMarcialis
Copy link
Contributor

As part of the our phased enhancements to the Lens annotation feature, we've recently added a new "Annotation groups" tab on the Kibana's visualize library page. This tab houses all saved annotations and is intended to allow users to perform a variety of CRUD operations. We have plans for further enhancements to this page, but it has been indicated that collaboration with the @elastic/appex-sharedux team would be needed to do so. Some of these enhancements include:

Header

  • We intended to use the gray background option for the page header on the page template. Is that possible to change?

Search & Filters

  • Our wireframe designs suggested the inclusion of a "Create annotation group" button to the right of the search/filter interface below the tabs. Would we be able to add a custom action here?

  • Should the "Tags" filter group button come before "Recently updated" (for both the "Visualization" and "Annotation groups" tabs)? I only ask because tags appear first when reading each table row.

  • This wasn't in the wireframes, but I was wondering if we'd have the ability to add a new filter group button for the "Data view" column in the "Annotation groups" tab. Is this something we can add?

Table

  • As part of a future addition, we'd like to add bulk actions for duplicating and merging annotation groups. Is it currently possible to support bulk actions beyond deleting?
    CleanShot 2023-09-08 at 16 51 41

  • Some of the table column widths seem overly narrow (excluding the "Name, description, tags" column, which appears excessively wide by contrast). Do we have the ability to increase the width of those narrow columns, or simply not apply a fixed width and let the browser decided based on table contents?
    image

  • Our wireframe designs suggested an action menu for each annotation row that offered edit, duplicate, and delete actions. The current action column only offers an edit action. Do we have the ability to add addition actions on each row?
    CleanShot 2023-09-08 at 16 53 12

  • Our wireframe designs also suggest the eventual addition of a new "Usages" column in the "Annotation groups" table that will indicate how many visualizations are currently utilizing each annotation group. Interacting with that count would reveal a flyout with a list of links for each visualization. Are we able to pull off something like that?

Regarding these enhancements, @drewdaemon from the Lens team mentioned the following in the most recent annotations PR:

The rest of your requests here depend on changes to shared-ux code. For example, the library components don’t support registering custom bulk actions. The content API is really the place to explore usage statistics.

Doesn’t mean we can’t do any of this, but it requires collaboration and is out-of-scope for the PR. I suggest you (or we) collect your feedback and submit it as a set of issues for the shared-ux team to own.

Is this something we can work with ya'll on to establish a priority and implement at some point?

CCing @timductive, @ninoslavmiskovic, @drewdaemon.

@MichaelMarcialis MichaelMarcialis added enhancement New value added to drive a business result Team:Visualizations Visualization editors, elastic-charts and infrastructure Feature:Lens Team:SharedUX Team label for AppEx-SharedUX (formerly Global Experience) Feature:Content Management User generated content (saved objects) management Component:TableListView labels Sep 19, 2023
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-visualizations (Team:Visualizations)

@stratoula stratoula added the impact:needs-assessment Product and/or Engineering needs to evaluate the impact of the change. label Sep 20, 2023
@timductive timductive added impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. and removed impact:needs-assessment Product and/or Engineering needs to evaluate the impact of the change. labels Sep 20, 2023
@timductive
Copy link
Member

For now we are prioritizing this low while we wait for customer feedback. In the future we can break out the features and prioritize them with corresponding projects (like Content Management)

@petrklapka
Copy link
Member

From today's Jam Session meeting: Thanks for the contextualization @kevinsweet !

We decided that asks like this can be supported by the "1.0" version of TableListView. A refactor to a composited control backed by unified interface like CM is on the horizon, but we're thinking 6 to 12 months out.

To support this issue, what is the "hottest" concrete ask, and what are the top three asks? Lets break this down.

@MichaelMarcialis
Copy link
Contributor Author

To support this issue, what is the "hottest" concrete ask, and what are the top three asks? Lets break this down.

Not sure if this was directed to me, but from my perspective, I'd consider the following three items most important (ordered by priority):

  1. Support for additional customizable row-level actions, beyond the current "edit" and "view details" action. This should also include support for an overflow/more button to display a menu of additional non-primary actions.
  2. Support for additional customizable bulk actions, beyond the current bulk delete action.
  3. Support for additional customizable columns in the table.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component:TableListView enhancement New value added to drive a business result Feature:Content Management User generated content (saved objects) management Feature:Lens impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. Team:SharedUX Team label for AppEx-SharedUX (formerly Global Experience) Team:Visualizations Visualization editors, elastic-charts and infrastructure
Projects
None yet
Development

No branches or pull requests

6 participants