Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Dashboards] Dashboards should only have single React render tree #166214

Closed
Tracked by #166211
thomasneirynck opened this issue Sep 11, 2023 · 6 comments
Closed
Tracked by #166211

[Dashboards] Dashboards should only have single React render tree #166214

thomasneirynck opened this issue Sep 11, 2023 · 6 comments
Assignees
@ThomThomson
Labels
chore Feature:Dashboard Dashboard related features Feature:Embeddables Relating to the Embeddable system impact:critical This issue should be addressed immediately due to a critical level of impact on the product. loe:x-large Extra Large Level of Effort Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas

Comments

@thomasneirynck
Copy link
Contributor

Dashboards now are made up of a number of Embeddables. Each have their own render tree. For more efficient DOM manipulation, Dashboards should only have a single render tree.

This will cut down on progressive loading.

This is a micro-optimization but points at a foundational issue with the Embeddable system; Embeddables are not instances of ReactComponent. Most other UX building blocks in Kibana are ReactComponents.
@thomasneirynck thomasneirynck added chore Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas labels Sep 11, 2023
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-presentation (Team:Presentation)

@thomasneirynck thomasneirynck mentioned this issue Sep 11, 2023
Closed
19 tasks
@vadimkibana
Copy link
Contributor

A broader follow-up would be that the whole Kibana should be a single React render context.

@ThomThomson ThomThomson added Feature:Dashboard Dashboard related features loe:x-large Extra Large Level of Effort impact:critical This issue should be addressed immediately due to a critical level of impact on the product. Feature:Embeddables Relating to the Embeddable system labels Sep 12, 2023
@ThomThomson
Copy link
Contributor

ThomThomson commented Sep 12, 2023 •
edited
Loading

Giving this an extra large LOE because this is one of the primary goals of the Embeddables redesign. When I open issues for that, I will mark this as blocked.

@thomasneirynck
Copy link
Contributor Author

Changing to in-progress, as Embeddable refactor is in progress

@thomasneirynck
Copy link
Contributor Author

dupe of #167429

@thomasneirynck
Copy link
Contributor Author

done with #186642

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ThomThomson ThomThomson

Labels
chore Feature:Dashboard Dashboard related features Feature:Embeddables Relating to the Embeddable system impact:critical This issue should be addressed immediately due to a critical level of impact on the product. loe:x-large Extra Large Level of Effort Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@thomasneirynck @ThomThomson @elasticmachine @vadimkibana