Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Cloud Security][Findings++ Phase 1] Implement persistance of column order/widths #165785

Closed
mitodrummer opened this issue Sep 5, 2023 · 2 comments · Fixed by #167587
Closed
Assignees
Labels
8.11 candidate enhancement New value added to drive a business result Feature:Cloud-Security Cloud Security related features Team:Cloud Security Cloud Security team related verified

Comments

@mitodrummer
Copy link
Contributor

mitodrummer commented Sep 5, 2023

Motivation

The 'unified-data-table' package contains callbacks to allow us to save the column layout and individual widths. Currently we store "pageSize" option in localstorage. Columns should be stored in a similar matter.

Definition of done

  • Re-ordering of columns and adjustments of column width should persist between page refreshes. (local storage ok, but worth exploring other solutions)
  • Logic wrt to column layout persistance etc.. should be contained within the common table component
  • A "localStorageKey" or "tableSettingsKey" prop should be added to the "common table" component to allow for each table in CSP to have it's own persisted config. (each table will have a different set of columns defaults available, so we can't share column layouts between tables)
  • Ensure testing happens for both ESS and serverless modes of operation

Out of scope

  • [ ]

Related tasks

@mitodrummer mitodrummer added enhancement New value added to drive a business result Team:Cloud Security Cloud Security team related 8.11 candidate labels Sep 5, 2023
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-cloud-security-posture (Team:Cloud Security)

@kfirpeled kfirpeled added the Feature:Cloud-Security Cloud Security related features label Sep 6, 2023
@kfirpeled kfirpeled assigned opauloh and unassigned mitodrummer Sep 19, 2023
@opauloh opauloh linked a pull request Oct 1, 2023 that will close this issue
@kfirpeled kfirpeled linked a pull request Oct 3, 2023 that will close this issue
@oren-zohar
Copy link
Contributor

Verified:

Image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
8.11 candidate enhancement New value added to drive a business result Feature:Cloud-Security Cloud Security related features Team:Cloud Security Cloud Security team related verified
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants