Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Cloud Security][Findings++ Phase 1] Create common table component using unified-data-table package #165784

Closed
mitodrummer opened this issue Sep 5, 2023 · 3 comments · Fixed by #167587
Assignees
Labels
8.11 candidate enhancement New value added to drive a business result Feature:Cloud-Security Cloud Security related features Team:Cloud Security Cloud Security team related

Comments

@mitodrummer
Copy link
Contributor

mitodrummer commented Sep 5, 2023

Motivation

Yuliia is currently working on extracting the discover grid into a package called "unified-data-table". This component checks all the boxes we need for the findings/vuln data grids, and more importantly is a path to avoid having to re-invent the wheel and create a completely different experience from the rest of Kibana.

PR for unified-data-table package: https://github.com/elastic/kibana/pull/163211/files#diff-1cb21a17baad332c946437e62ef2bef10ba53741eb74385a245d26242d462360

Definition of done

  • Create a new common "cloud security data grid" component that uses 'unified-data-table' package and abstracts all common code related to tables across our solutions. The interface should be as lean as possible to make adoption in other pages a breeze.
  • A re-useable generic interface should be created to define the set of default columns, display names, and custom cell renderers.
  • As part of this ticket the "latest_findings" page should adopt this new component/hook/interface.
  • Ensure testing happens for both ESS and serverless modes of operation

Out of scope

  • persistence of column layout
  • fields api to dynamically select columns from derive fields in doc, or runtime fields.
  • other tables to be updated in separate tickets.

Related tasks/epics

@mitodrummer mitodrummer self-assigned this Sep 5, 2023
@mitodrummer mitodrummer added the Team:Cloud Security Cloud Security team related label Sep 5, 2023
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-cloud-security-posture (Team:Cloud Security)

@mitodrummer mitodrummer added enhancement New value added to drive a business result 8.11 candidate labels Sep 5, 2023
@kfirpeled kfirpeled added the Feature:Cloud-Security Cloud Security related features label Sep 6, 2023
@kfirpeled kfirpeled assigned opauloh and unassigned mitodrummer Sep 19, 2023
@kfirpeled
Copy link
Contributor

PR: #167587

@kfirpeled kfirpeled changed the title [Cloud Security][Findings++ Phase 1] Create common table component using "unified-data-table" package [Cloud Security][Findings++ Phase 1] Create common table component using unified-data-table package Oct 3, 2023
@kfirpeled kfirpeled linked a pull request Oct 3, 2023 that will close this issue
@kfirpeled kfirpeled linked a pull request Oct 3, 2023 that will close this issue
@kfirpeled
Copy link
Contributor

This PR is also related: #167725

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
8.11 candidate enhancement New value added to drive a business result Feature:Cloud-Security Cloud Security related features Team:Cloud Security Cloud Security team related
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants