Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Lens] Making chart axis more readable in dark mode #165348

Open
Tracked by #175869
iamhowardtheduck opened this issue Aug 31, 2023 · 5 comments
Open
Tracked by #175869

[Lens] Making chart axis more readable in dark mode #165348

iamhowardtheduck opened this issue Aug 31, 2023 · 5 comments
Labels
enhancement New value added to drive a business result Feature:Lens impact:medium Addressing this issue will have a medium level of impact on the quality/strength of our product. Team:Visualizations Visualization editors, elastic-charts and infrastructure

Comments

@iamhowardtheduck
Copy link

Currently the time chart on Lens or other visualizations are grey, would like to customize this as it is an ask from many users and customers.

That grey is very hard to read when in dark mode, would like to customize to any color a user prefers.
image

@botelastic botelastic bot added the needs-team Issues missing a team label label Aug 31, 2023
@dej611 dej611 added enhancement New value added to drive a business result Team:Visualizations Visualization editors, elastic-charts and infrastructure Feature:Lens labels Sep 4, 2023
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-visualizations (Team:Visualizations)

@botelastic botelastic bot removed the needs-team Issues missing a team label label Sep 4, 2023
@dej611
Copy link
Contributor

dej611 commented Sep 4, 2023

If the problem is just a specific solution integration customization, then I think passing thru Embeddable overrides is the main route. The library already supports fine control over axis theme styling, you can test it here: https://elastic.github.io/elastic-charts/?path=/story/stylings--axis&globals=toggles.showHeader:true;toggles.showChartTitle:false;toggles.showChartDescription:false;theme:light

If we're talking instead about general styling issue it would be nice to have some more feedback here to change such important aspect, and perhaps have some written guidelines also on the EUI side: https://elastic.github.io/eui/#/elastic-charts/time-series

cc @gvnmagni @markov00

@gvnmagni
Copy link

gvnmagni commented Sep 4, 2023

It would be important to understand if this request come from the desire of customizing the aspects of charts (therefore a sort of Branding issue) or if it is an issue of readability and accessibility. Peter could you please provide a little bit of background for this issue? Would be great to know more

The reason why I say this is that we probably don't want users to be able to make yellow labels because they like that, but on the other side we need to be sure that they are readable, this would be an important concern.

@stratoula
Copy link
Contributor

stratoula commented Sep 4, 2023

I agree with @gvnmagni that giving freedom to the users for the tick labels is possibly something we don't want but I also agree with @iamhowardtheduck that in dark mode they are difficult to read. Maybe the solution here is to find a better default for dark mode?

@stratoula stratoula added the impact:needs-assessment Product and/or Engineering needs to evaluate the impact of the change. label Sep 6, 2023
@timductive timductive added impact:medium Addressing this issue will have a medium level of impact on the quality/strength of our product. and removed impact:needs-assessment Product and/or Engineering needs to evaluate the impact of the change. labels Sep 6, 2023
@dej611
Copy link
Contributor

dej611 commented Apr 15, 2024

+1 https://discuss.elastic.co/t/how-to-change-axis-tick-label-colors-in-kibana-dark-theme-for-better-readability/356085/3

@teresaalvarezsoler teresaalvarezsoler changed the title Customize chart color from grey to whatever Making chart axis more readable in dark mode Sep 19, 2024
@mbondyra mbondyra changed the title Making chart axis more readable in dark mode [Lens] Making chart axis more readable in dark mode Nov 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New value added to drive a business result Feature:Lens impact:medium Addressing this issue will have a medium level of impact on the quality/strength of our product. Team:Visualizations Visualization editors, elastic-charts and infrastructure
Projects
None yet
Development

No branches or pull requests

8 participants