Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Telemetry schema needs to include key from functional test in reporting #164867

Closed
rshen91 opened this issue Aug 25, 2023 · 1 comment · Fixed by #164871
Closed

Telemetry schema needs to include key from functional test in reporting #164867

rshen91 opened this issue Aug 25, 2023 · 1 comment · Fixed by #164871
Assignees
Labels
bug Fixes for quality problems that affect the customer experience Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc telemetry Issues related to the addition of telemetry to a feature test

Comments

@rshen91
Copy link
Contributor

rshen91 commented Aug 25, 2023

In PR #163354, we ran into CI failures for the serverless functional testx-pack/test_serverless/api_integration/test_suites/observability/telemetry/snapshot_telemetry.ts.

The PR skips the test causing this error in x-pack/test_serverless/api_integration/test_suites/common/reporting/download_csv_dashboard.ts as a workaround.

Can this key be added to the schema or have a way in the future for tests to update the schema in the snapshot_telemetry.ts test?
stack_stats.kibana.plugins.core.apiCalls.savedObjectsImport.compatibilityModeEnabled.no

That way when running node ./scripts/functional_tests.js --config=x-pack/test_serverless/api_integration/test_suites/search/config.ts --grep="CSV Generation from SearchSource: Dashboard|API Snapshot telemetry should pass the schema validation" it doesn't matter if download_csv_dashboard.ts executes first or snapshot_telemetry.ts.

Thanks!

@rshen91 rshen91 added bug Fixes for quality problems that affect the customer experience test Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc telemetry Issues related to the addition of telemetry to a feature labels Aug 25, 2023
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-core (Team:Core)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Fixes for quality problems that affect the customer experience Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc telemetry Issues related to the addition of telemetry to a feature test
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants