Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fleet] Rename templates and pipelines according to the naming conventions #164065

Closed
felixbarny opened this issue Aug 16, 2023 · 8 comments
Closed
Labels
Team:Fleet Team label for Observability Data Collection Fleet team

Comments

@felixbarny
Copy link
Member

See elastic/elasticsearch#96267

@felixbarny felixbarny added the Team:Fleet Team label for Observability Data Collection Fleet team label Aug 16, 2023
@elasticmachine
Copy link
Contributor

Pinging @elastic/fleet (Team:Fleet)

@jlind23
Copy link
Contributor

jlind23 commented Aug 16, 2023

@felixbarny Is this something we (fleet) should take on?

@felixbarny
Copy link
Member Author

Hey Julien, good question. I think a contribution from o11y may be feasible. However, I think it would be a safer if this is done from the Fleet team. There are a few delicate things to consider around backwards compatibility so I'd prefer this to be implemented by the core Fleet team to lower that risk. Also, I don't see this task as urgent.

@felixbarny
Copy link
Member Author

Ok, so this is the diff of the current names vs the new naming convention:

Current name type new name
.fleet_globals-1 component template data-stream@mappings
.fleet_agent_id_verification-1 component template agent-id-verification@settings
.fleet_final_pipeline-1 ingest pipeline   agent-id-verification@pipeline

For data-stream@mappings, we could import that component template from ES rather than defining a Fleet-specific one. The contents are slightly different at the moment, however.

I don't think these are particularly high priority to rename to be honest. The most important ones are the names for *@package and *@custom, which are already aligned with the new naming convention.

Technically, the new naming convention also proposes to suffix index templates with *@template. However, we haven't actually made that change in the ES index templates due to backwards compatibility concerns and because there's no way to atomically rename a component template. See elastic/elasticsearch@7fd0423 for details. Therefore, I don't think we need to do that change in Fleet, either.

@joshdover @ruflin do you think it's with aligning these .fleet* components with the new naming convention? I'm on the fence if this is time well spent.

@ruflin
Copy link
Contributor

ruflin commented Nov 17, 2023

My assumption on 2 and 3 are that these are not assets that we would expect users ever to reuse? I'm stumbling over .fleet_globals-1. What is the exact content? Do we expect users to reuse it?

@felixbarny
Copy link
Member Author

The .fleet_globals-1 component template disables date detection and adds a dynamic template for strings as keywords.

This is similar to the data_streams@mappings component template which adds some more dynamic templates for ip and message, and adds mappings for @timestamp, data_stream fields, ecs.version, and host. Not entirely sure what the state of component template is. We don't use it for logs-*-* anymore in favor of the ecs@mappings component template.

@ruflin
Copy link
Contributor

ruflin commented Nov 20, 2023

In this case, I would also ignore .fleet_globas-1. My understanding is that eventually this will be faced out and if a user wants to component template to reuse, they should use data_stream@mappings instead.

@felixbarny
Copy link
Member Author

Alright, I'll close this as not planned then.

@felixbarny felixbarny closed this as not planned Won't fix, can't repro, duplicate, stale Nov 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Team:Fleet Team label for Observability Data Collection Fleet team
Projects
None yet
Development

No branches or pull requests

4 participants