-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
getTagList returns incorrect result if tags are create after page loaded: #160723
Comments
Pinging @elastic/appex-sharedux (Team:SharedUX) |
Hey @angorayc , sorry I must be very slow. In the video you show:
Isn't that what is expected? Not sure I see the issue. |
It is possible that #160871 fixed this issue. |
This issue requires #160540 to be merged to be able to test and debug it. As discussed over Slack you found a workaround so we can de-prioritise it and I'll have a look in a future sprint. Note to clarify the issue: this is an edge case where the page embedding the TableListView component creates a new tag when being accessed which apparently is not visible by the tag filter panel of the table. In theory it should work as we fetch the tag list every time the tag panel opens (https://github.com/elastic/kibana/blob/main/packages/content-management/table_list_view_table/src/components/use_tag_filter_panel.tsx#L168 & https://github.com/elastic/kibana/blob/main/packages/content-management/table_list_view_table/src/components/use_tag_filter_panel.tsx#L83) which get the latest state of the tags cache https://github.com/elastic/kibana/blob/main/x-pack/plugins/saved_objects_tagging/public/ui_api/get_tag_list.ts#L11). |
Pinging @elastic/security-threat-hunting (Team:Threat Hunting) |
Pinging @elastic/security-solution (Team: SecuritySolution) |
Looking at the export const createTag = (
{ http, tag }: { http: HttpSetup; tag: Omit<TagAttributes, 'color'> & { color?: string } },
abortSignal?: AbortSignal
): Promise<Tag> =>
http.put(INTERNAL_TAGS_URL, {
body: JSON.stringify(tag),
signal: abortSignal,
}); which is not using the To solve this issue you need to create your tag using the |
getTagList
returns incorrect result if tags are create after page loaded (Hopefully we could get this in 8.10)Steps to reproduce (as shown in the video below):
remove_tags.mov
Originally posted by @angorayc in #160540 (comment)
The text was updated successfully, but these errors were encountered: