Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Telemetry] Add FTRs to validate the expected behavior of the banners #159892

Open
afharo opened this issue Jun 19, 2023 · 2 comments
Open

[Telemetry] Add FTRs to validate the expected behavior of the banners #159892

afharo opened this issue Jun 19, 2023 · 2 comments
Labels
Feature:Telemetry Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc technical debt Improvement of the software architecture and operational architecture

Comments

@afharo
Copy link
Member

afharo commented Jun 19, 2023

To avoid introducing regressions such as #159870, we should write FTRs that test the functional expected behavior of the banners:

  1. When telemetry.optIn: true (or not explicitly specified), show the banner to inform the user.
  2. When Opted-In via Advanced settings, do not show the banner anymore (not even for newer versions).
  3. When telemetry.optIn: false (on fresh Kibana install), show the banner to inform the user.
  4. When opted-out (either via telemetry.optIn: false or via Advanced Settings), and only notified in a previous minor, notify again.
  5. No notifications showed when telemetry.banner: false or allowChangingOptInStatus: false.

I didn't introduce these new FTRs when fixing #159870 because, currently, our functional tests have the banners explicitly disabled, and I didn't want to miss the chance to ship the bug to 8.8.2

@afharo afharo added Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc Feature:Telemetry technical debt Improvement of the software architecture and operational architecture labels Jun 19, 2023
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-core (Team:Core)

@afharo
Copy link
Member Author

afharo commented Jun 19, 2023

I noticed https://github.com/elastic/kibana/blob/main/test/plugin_functional/test_suites/telemetry/telemetry.ts already tests most of it.

We only need to test the dismissal button.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature:Telemetry Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc technical debt Improvement of the software architecture and operational architecture
Projects
None yet
Development

No branches or pull requests

2 participants