Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove duplicate App Services type #158143

Closed
CoenWarmer opened this issue May 20, 2023 · 1 comment · Fixed by #158144
Closed

Remove duplicate App Services type #158143

CoenWarmer opened this issue May 20, 2023 · 1 comment · Fixed by #158144
Assignees
@CoenWarmer
Labels
Team: Actionable Observability - DEPRECATED For Observability Alerting and SLOs use "Team:obs-ux-management", for AIops "Team:obs-knowledge"

Comments

@CoenWarmer
Copy link
Contributor

CoenWarmer commented May 20, 2023 •
edited
Loading

Part of #152783

📝 Summary

There is an interface defined in x-pack/plugins/observability/public/application/type.ts called ObservabilityAppServices. This type is essentially a duplicate of the ObservabilityPublicPluginsStart interface which is defined in x-pack/plugins/observability/public/plugin.ts.

Lets remove it so there can be no confusion as to what type to use.

✅ Acceptance criteria

  • The interface ObservabilityAppServices in x-pack/plugins/observability/public/application/type.ts should be removed
  • All references should be updated to use the one in x-pack/plugins/observability/public/plugin.ts.
@CoenWarmer CoenWarmer self-assigned this May 20, 2023
@botelastic botelastic bot added the needs-team Issues missing a team label label May 20, 2023
This was referenced May 20, 2023
Merged
Closed
@CoenWarmer CoenWarmer added the Team: Actionable Observability - DEPRECATED For Observability Alerting and SLOs use "Team:obs-ux-management", for AIops "Team:obs-knowledge" label May 20, 2023
@elasticmachine
Copy link
Contributor

Pinging @elastic/actionable-observability (Team: Actionable Observability)

@botelastic botelastic bot removed the needs-team Issues missing a team label label May 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@CoenWarmer CoenWarmer

Labels
Team: Actionable Observability - DEPRECATED For Observability Alerting and SLOs use "Team:obs-ux-management", for AIops "Team:obs-knowledge"
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Cleanup extraneous Observability Services type CoenWarmer/kibana
2 participants
@CoenWarmer @elasticmachine