Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Visualize legend doesn't update when uiState changes #15736

Closed
timroes opened this issue Dec 21, 2017 · 4 comments
Closed

Visualize legend doesn't update when uiState changes #15736

timroes opened this issue Dec 21, 2017 · 4 comments
Labels
bug Fixes for quality problems that affect the customer experience Feature:Visualizations Generic visualization features (in case no more specific feature label is available) still valid? Team:Visualizations Visualization editors, elastic-charts and infrastructure

Comments

@timroes
Copy link
Contributor

timroes commented Dec 21, 2017 •
edited
Loading

As described in #15728 the legend of a visualization doesn't correctly update whenever the uiState change. The legend should update when anything in the uiState is changing, by listening on it's attached uiState.
@timroes timroes added Feature:Visualizations Generic visualization features (in case no more specific feature label is available) bug Fixes for quality problems that affect the customer experience labels Dec 21, 2017
@timroes timroes self-assigned this Dec 21, 2017
This was referenced Dec 21, 2017
Closed
Closed
@timroes
Copy link
Contributor Author

timroes commented Jan 16, 2018

Blocked by #15728

@timroes timroes removed the blocked label Mar 9, 2018
@LeeDr LeeDr mentioned this issue Jul 17, 2018
Open
@cjcenizal
Copy link
Contributor

@timroes The referenced PR was merged so is this issue still valid?

@timroes
Copy link
Contributor Author

timroes commented Jul 27, 2018 •
edited
Loading

The issue is still valid, but it's not blocked anymore. We could potentially fix that, but it's super prio on our list, since this only happens if a user manually tries to mess with the URL to change colors in the URL, that then won't update in the Legend (only the chart) until the next page reload.

This cannot be triggered by using the UI itself.

@timroes timroes added the Team:Visualizations Visualization editors, elastic-charts and infrastructure label Sep 16, 2018
@timroes timroes removed their assignment Apr 16, 2019
@timroes
Copy link
Contributor Author

timroes commented Feb 27, 2020

Tested this, since does not occur on the latest releases most likely due to our state management changes.

@timroes timroes closed this as completed Feb 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Fixes for quality problems that affect the customer experience Feature:Visualizations Generic visualization features (in case no more specific feature label is available) still valid? Team:Visualizations Visualization editors, elastic-charts and infrastructure
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@timroes @cjcenizal