Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Lens][Embeddable] Unnecessary information in request #156736

Closed
Tracked by #184459
angorayc opened this issue May 4, 2023 · 7 comments
Closed
Tracked by #184459

[Lens][Embeddable] Unnecessary information in request #156736

angorayc opened this issue May 4, 2023 · 7 comments
Labels
enhancement New value added to drive a business result Feature:Lens Charts Security Solution Lens Charts feature 🧊 iceboxed impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. Team:Visualizations Visualization editors, elastic-charts and infrastructure

Comments

@angorayc
Copy link
Contributor

angorayc commented May 4, 2023

When Open a Lens Embeddable in Lens. The following sections of the request may be unnecessary:

Screenshot 2023-05-04 at 18 25 50

  • fields
  • runtime_mappings
  • script_fields
  • stored_fields

Originally posted by @andrew-goldstein in #156318 (comment)

@botelastic botelastic bot added the needs-team Issues missing a team label label May 4, 2023
@angorayc angorayc added Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. and removed needs-team Issues missing a team label labels May 4, 2023
@elasticmachine
Copy link
Contributor

Pinging @elastic/security-solution (Team: SecuritySolution)

@angorayc angorayc changed the title Unnecessary information request [Lens][Embeddable] Unnecessary information in request May 4, 2023
@angorayc angorayc added Team:Visualizations Visualization editors, elastic-charts and infrastructure Feature:Lens Charts Security Solution Lens Charts feature labels May 4, 2023
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-visualizations @elastic/kibana-visualizations-external (Team:Visualizations)

@stratoula stratoula added enhancement New value added to drive a business result impact:needs-assessment Product and/or Engineering needs to evaluate the impact of the change. labels May 5, 2023
@stratoula
Copy link
Contributor

@elastic/kibana-data-discovery I guess this is how the response comes from the search api. Not sure what we can do for that, any ideas?

@dej611
Copy link
Contributor

dej611 commented May 26, 2023

I did look into this a little bit, and requests can be a bit smarter looking at the query content.
I guess this can be a potential performance hit for dataViews with a huge number of fields, but on average I think is not that bad. @angorayc are you hitting some performance problems with that?

@drewdaemon
Copy link
Contributor

Partial duplicate of #139025

@timductive timductive added impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. and removed impact:needs-assessment Product and/or Engineering needs to evaluate the impact of the change. labels May 31, 2023
@timductive
Copy link
Member

@angorayc is this a performance concern or a UX concern?

@markov00
Copy link
Member

markov00 commented Jun 3, 2024

In order to provide better transparency of priorities, issues that will not be prioritized within the next 24 months are being closed.

Tracking request in Lens general improvements ice box #184459

@markov00 markov00 closed this as not planned Won't fix, can't repro, duplicate, stale Jun 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New value added to drive a business result Feature:Lens Charts Security Solution Lens Charts feature 🧊 iceboxed impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. Team:Visualizations Visualization editors, elastic-charts and infrastructure
Projects
None yet
Development

No branches or pull requests

7 participants