Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SLO][SLO Detail] Header Actions menu should offer the same options as SLO List Item > Actions menu #155849

Closed
CoenWarmer opened this issue Apr 26, 2023 · 1 comment · Fixed by #155868
Assignees
Labels
Team: Actionable Observability - DEPRECATED For Observability Alerting and SLOs use "Team:obs-ux-management", for AIops "Team:obs-knowledge"

Comments

@CoenWarmer
Copy link
Contributor

CoenWarmer commented Apr 26, 2023

📝 Summary

The SLO Detail > Header Actions and the SLO List Item > Actions menus are inconsistent.

Options
The SLO Detail > Header Actions menu has options for:

  • Edit
  • Create new Alert rule
  • Manage rules
  • (if APM SLI) Explore in APM

The SLO List item > Actions menu has options for:

  • Edit
  • Create new Alert rule
  • Manage rules
  • (if APM SLI) Explore in APM
  • Clone
  • Delete

Icons
The SLO List Item > Actions menu options have icons, the SLO Details > Header Actions menu options do not.

Padding
The paddings are not the same.

Inconsistent capitalisation
"Add Alert rule" is spelled differently in both menus.

Lets make the menus consistent with each other.

✅ Acceptance criteria

  • The SLO Detail > Header actions menu should also have "Clone"
  • The SLO Detail > Header actions menu should also have "Delete"
  • Both menus should use "medium" padding
  • Both menus should use the gear icon for "Manage rules"
  • The SLO Detail > Header actions menu should also have icons, same as SLO List item
  • The SLO Detail > Header actions menu > Create new Alert rule option should have the same capitalization as on SLO List Item > Actions menu option
@CoenWarmer CoenWarmer self-assigned this Apr 26, 2023
@botelastic botelastic bot added the needs-team Issues missing a team label label Apr 26, 2023
@CoenWarmer CoenWarmer added the Team: Actionable Observability - DEPRECATED For Observability Alerting and SLOs use "Team:obs-ux-management", for AIops "Team:obs-knowledge" label Apr 26, 2023
@elasticmachine
Copy link
Contributor

Pinging @elastic/actionable-observability (Team: Actionable Observability)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Team: Actionable Observability - DEPRECATED For Observability Alerting and SLOs use "Team:obs-ux-management", for AIops "Team:obs-knowledge"
Projects
None yet
2 participants