Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Portable Dashboard] Allow for Non-Removable Tags in Portable Dashboard Listing Page #155089

Closed
ThomThomson opened this issue Apr 17, 2023 · 5 comments
Labels
Feature:Dashboard Dashboard related features impact:high Addressing this issue will have a high level of impact on the quality/strength of our product. loe:large Large Level of Effort Project:Portable Dashboard Related to the Portable Dashboards initiative Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas

Comments

@ThomThomson
Copy link
Contributor

Feature

The security solution is planning to adopt the Dashboard Listing page which was exported in #154295, but that listing page is missing some required functionality, specifically the ability to set a read-only or hidden tag that filters the listing page. They need this to ensure that only dashboards marked with the security solution tag appear in their list.

@ThomThomson ThomThomson added Feature:Dashboard Dashboard related features Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas loe:large Large Level of Effort impact:high Addressing this issue will have a high level of impact on the quality/strength of our product. Project:Portable Dashboard Related to the Portable Dashboards initiative labels Apr 17, 2023
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-presentation (Team:Presentation)

@angorayc
Copy link
Contributor

angorayc commented Apr 25, 2023

Thanks for following this up @ThomThomson.
I've tried to implement it in SecuritySolution's page (#155716), the table looks great!
I can see that the header and the create dashboard button is part of the component, can we have an option to hide them? As we would like to use our own header (as we have some custom styling) and create dashboard button (which eventually will create a dashboard without leaving SecuritySolution app).

Portable dashboard header applied:
Screenshot 2023-04-25 at 14 57 24

Expected:
Screenshot 2023-04-25 at 15 00 57

Another observation I have is: I clicked on a random dashboard from the listing and it's not happy about the relevant time range.
Screenshot 2023-04-25 at 13 47 49

@ThomThomson
Copy link
Contributor Author

Hi @angorayc! For using the dashboard listing page without the page template, we'll actually need to make changes in the TableListView, because the page template is coming from there. @elastic/appex-sharedux, is there an issue already to provide a version of TableListView that doesn't contain the page template?

In terms of the time range, I'm not exactly sure what is going on there. Which type is this panel?

@angorayc
Copy link
Contributor

We can close this issue as the request has changed. The new request is: allow for (removable) default selected tags. Implemented in #160540

@ThomThomson
Copy link
Contributor Author

Sure I can close this for now. Will continue the discussions in #160540 !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature:Dashboard Dashboard related features impact:high Addressing this issue will have a high level of impact on the quality/strength of our product. loe:large Large Level of Effort Project:Portable Dashboard Related to the Portable Dashboards initiative Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas
Projects
None yet
Development

No branches or pull requests

3 participants