Maps embeddables in a dashboard not capturing map id in execution context

[rudolf]

To reproduce:

1. Install sample flights data
2. Log elasticsearch queries by adding the following to kibana.yml

    logging:
      loggers:
        - name: elasticsearch.query
          level: debug
    logging.appenders.default:
       type: console
       layout:
         type: json
   

3. Open the [Flights] Global Flight Dashboard

The X-Opaque-Id in the logs will contain entries like:

871c9395-5866-4135-99a9-e83c9858cc72;kibana:application:discover:new;application:dashboards:7adfa750-4c81-11e8-b3d7-01146121b73d;application:maps: // <-- NOTE missing map id makes it hard to attribute request to a specific map

In contrast to lens embeddables which create entries like:

871c9395-5866-4135-99a9-e83c9858cc72;kibana:application:discover:new;dashboard:dashboards:7adfa750-4c81-11e8-b3d7-01146121b73d;lens:lnsXY:0cc42484-16f7-42ec-b38c-9bf8be69cde7

Opening the map to edit it does produce the correct execution context, so it seems like the problem is the execution context is not correctly captured by the maps embeddable.

[elasticmachine]

Pinging @elastic/kibana-presentation (Team:Presentation)

[nreese]

Map id is not populated for embeddable maps because of the way executionContext is created by makePublicExecutionContext. makePublicExecutionContext does not take id as a parameter, instead getting id via executionContextServiceStart.get(). When a map is embedded, executionContextServiceStart.get() returns the id of the parent and not the id of the map so id in the map child context is not populated.

export function makePublicExecutionContext(description: string): KibanaExecutionContext {
  const topLevelContext = getExecutionContext().get();
  const context = makeExecutionContext({
    url: window.location.pathname,
    description,
  });

  // Distinguish between running in maps app vs. embedded
  return topLevelContext.name !== undefined && topLevelContext.name !== context.name
    ? {
        ...topLevelContext,
        child: context,
      }
    : {
        ...topLevelContext,
        ...context,
      };
}

[nreese]

closed by #153616