Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

k4b1: Tarball has 2 copies of JRuby #1532

Closed
jordansissel opened this issue Oct 6, 2014 · 3 comments
Closed

k4b1: Tarball has 2 copies of JRuby #1532

jordansissel opened this issue Oct 6, 2014 · 3 comments
Assignees
Labels
blocker bug Fixes for quality problems that affect the customer experience
Milestone

Comments

@jordansissel
Copy link
Contributor

% jar xvf kibana.jar
8707954 Mon Oct 06 09:18:20 UTC 2014 META-INF/lib/jruby-stdlib-complete-1.7.13.jar
8707954 Mon Oct 06 09:18:22 UTC 2014 gems/jruby-jars-1.7.13/lib/jruby-stdlib-complete-1.7.13.jar
13297027 Mon Oct 06 09:18:20 UTC 2014 META-INF/lib/jruby-core-complete-1.7.13.jar
13297027 Mon Oct 06 09:18:22 UTC 2014 gems/jruby-jars-1.7.13/lib/jruby-core-complete-1.7.13.jar

There's two copies of 'jruby stldib' and 'jruby core' each. I suspect we only need the one?

The impact is that the resulting kibana.jar is probably ~10-20MB larger than required.

@rashidkpc rashidkpc added this to the 4.0.0-BETA2 milestone Oct 6, 2014
@rashidkpc rashidkpc added bug Fixes for quality problems that affect the customer experience and removed v4.0.0-BETA1 labels Oct 6, 2014
@simianhacker simianhacker self-assigned this Oct 7, 2014
@simianhacker
Copy link
Member

The solution to this is to remove the "warbler" dependency from the Gemfile (src/server/Gemfile)

@simianhacker
Copy link
Member

I will probably add a second Gemfile in the root of the project to ensure that the proper dependencies are included for building the project vs the deployment dependencies.

@jordansissel
Copy link
Contributor Author

You don't need a separate gemfile - you can use groups inside the Gemfile, check out: http://bundler.io/v1.6/groups.html

Example:

group :build do
  gem "warbler"
end

This allows you to do 'bundle install --with build' to get normal + build dependencies, but the normal deps won't include warbler.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
blocker bug Fixes for quality problems that affect the customer experience
Projects
None yet
Development

No branches or pull requests

3 participants