Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adjust folder structure in SLO Edit page #152795

Closed
5 tasks done
CoenWarmer opened this issue Mar 7, 2023 · 0 comments · Fixed by #152905
Closed
5 tasks done

Adjust folder structure in SLO Edit page #152795

CoenWarmer opened this issue Mar 7, 2023 · 0 comments · Fixed by #152905
Assignees
@CoenWarmer
Labels
Team: Actionable Observability - DEPRECATED For Observability Alerting and SLOs use "Team:obs-ux-management", for AIops "Team:obs-knowledge" v8.8.0

Comments

@CoenWarmer
Copy link
Contributor

CoenWarmer commented Mar 7, 2023 •
edited
Loading

Part of #152783

Summary

Let's adjust the folder structure of the SLO Edit page as agreed upon by the team in the AO Team Time sessions.

✅ Acceptance criteria

  • Rename page component <to_name_of_page.tsx>
  • Remove /container subfolder if available
  • Remove /state_container subfolder if available
  • Try to inline translations in /translations.ts
  • Try to move re-used components to /app_root/components/feature
@CoenWarmer CoenWarmer added the Team: Actionable Observability - DEPRECATED For Observability Alerting and SLOs use "Team:obs-ux-management", for AIops "Team:obs-knowledge" label Mar 7, 2023
This was referenced Mar 7, 2023
Closed
Merged
@CoenWarmer CoenWarmer self-assigned this Apr 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@CoenWarmer CoenWarmer

Labels
Team: Actionable Observability - DEPRECATED For Observability Alerting and SLOs use "Team:obs-ux-management", for AIops "Team:obs-knowledge" v8.8.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[Tech Debt] Reorder SLO Edit page CoenWarmer/kibana
1 participant
@CoenWarmer