Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[http] Core's internal router needs to handle an access parameter #152282

Closed
TinaHeiligers opened this issue Feb 27, 2023 · 1 comment · Fixed by #156935
Closed

[http] Core's internal router needs to handle an access parameter #152282

TinaHeiligers opened this issue Feb 27, 2023 · 1 comment · Fixed by #156935
Labels
Epic:VersionedAPIs Kibana Versioned APIs Feature:http Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc

Comments

@TinaHeiligers
Copy link
Contributor

This issue is to handle the work needed for step 3 in
[http] Prevent access to internal-only APIs when running in serverless

Note: Some (if not most) of the individual issues might need t to be handled at the same time. For now, we assume that any work specifically addressing VersionedRouters can be done in parallel.

Adapt Core's internal router to handle the access parameter

Core's internal routing system should properly use this access parameter. When accessing a route defined as internal, and when Kibana is configured accordingly (see point 6.), the system will check the presence of the x-elastic-internal-origin header, and return an error (403? other?) if the said header is not present.

Note: validation on the content of the header is probably not necessary, unless someone thinks otherwise.

@TinaHeiligers TinaHeiligers added Feature:http Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc Epic:VersionedAPIs Kibana Versioned APIs labels Feb 27, 2023
@botelastic botelastic bot added the needs-team Issues missing a team label label Feb 27, 2023
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-core (Team:Core)

@botelastic botelastic bot removed the needs-team Issues missing a team label label Feb 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Epic:VersionedAPIs Kibana Versioned APIs Feature:http Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants