Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[http] Current RouteConfigOptions should allow optionally declaring access #152269

Closed
TinaHeiligers opened this issue Feb 27, 2023 · 1 comment · Fixed by #152404
Closed

[http] Current RouteConfigOptions should allow optionally declaring access #152269

TinaHeiligers opened this issue Feb 27, 2023 · 1 comment · Fixed by #152404
Assignees
Labels
Epic:VersionedAPIs Kibana Versioned APIs Feature:http Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc

Comments

@TinaHeiligers
Copy link
Contributor

TinaHeiligers commented Feb 27, 2023

This issue is to handle the work needed for step 1 in
[http] Prevent access to internal-only APIs when running in serverless

Note: Some (if not most) of the individual issues might need to be handled at the same time. For now, we assume that any work specifically addressing VersionedRouters can be done in parallel.

Adapt the current server-side route declaration

Adapt RouteConfigOptions to:

  • Add a new optional access parameter
  • This parameter can be set to either public or internal.
  • When unspecified, the value is inferred from the route path:
    • If the path starts with /internal, it will default to internal.
    • Otherwise, it will default to public.
@botelastic botelastic bot added the needs-team Issues missing a team label label Feb 27, 2023
@TinaHeiligers TinaHeiligers added Epic:VersionedAPIs Kibana Versioned APIs and removed needs-team Issues missing a team label labels Feb 27, 2023
@botelastic botelastic bot added the needs-team Issues missing a team label label Feb 27, 2023
@TinaHeiligers TinaHeiligers added the Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc label Feb 27, 2023
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-core (Team:Core)

@botelastic botelastic bot removed the needs-team Issues missing a team label label Feb 27, 2023
@TinaHeiligers TinaHeiligers changed the title [http] RouteConfigOptions should allow optionally declaring access [http] Current RouteConfigOptions should allow optionally declaring access Feb 27, 2023
@TinaHeiligers TinaHeiligers self-assigned this Feb 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Epic:VersionedAPIs Kibana Versioned APIs Feature:http Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc
Projects
None yet
2 participants