[Embeddables] Reset, discard changes, or inline editing cancel can cause infinite loading

[bhavyarm]

Kibana version: 8.7.0 BC1

Elasticsearch version: 8.7.0 BC1

Server OS version: darwin_x86_64

Browser version: chrome latest

Browser OS version: OS X

Original install method (e.g. download page, yum, from source, etc.): from staging

Describe the bug: if user clicks on convert to lens ->lens app->replace in dashboard-> switch to view mode - discard changes - then that panel keeps loading infinitely.

Console error:

embeddable.plugin.js:1 Uncaught (in promise) TypeError: Cannot read properties of undefined (reading 'getOutput$')
    at embeddable_child_panel_EmbeddableChildPanel.componentDidMount (embeddable.plugin.js:1:41421)
componentDidMount @ embeddable.plugin.js:1
await in componentDidMount (async)
Ss @ kbn-ui-shared-deps-npm.dll.js:398
Wu @ kbn-ui-shared-deps-npm.dll.js:398
t.unstable_runWithPriority @ kbn-ui-shared-deps-npm.dll.js:406
$i @ kbn-ui-shared-deps-npm.dll.js:398
zu @ kbn-ui-shared-deps-npm.dll.js:398
Mu @ kbn-ui-shared-deps-npm.dll.js:398
(anonymous) @ kbn-ui-shared-deps-npm.dll.js:398
t.unstable_runWithPriority @ kbn-ui-shared-deps-npm.dll.js:406
$i @ kbn-ui-shared-deps-npm.dll.js:398
Zi @ kbn-ui-shared-deps-npm.dll.js:398
Ki @ kbn-ui-shared-deps-npm.dll.js:398
Au @ kbn-ui-shared-deps-npm.dll.js:398
(anonymous) @ dashboard.chunk.3.js:1
(anonymous) @ dashboard.chunk.3.js:1
Promise.then (async)
Ct @ dashboard.chunk.3.js:1
(anonymous) @ dashboard.chunk.3.js:1
run @ dashboard.chunk.3.js:1
onClick @ navigation.plugin.js:1
Ue @ kbn-ui-shared-deps-npm.dll.js:398
Xe @ kbn-ui-shared-deps-npm.dll.js:398
(anonymous) @ kbn-ui-shared-deps-npm.dll.js:398
jr @ kbn-ui-shared-deps-npm.dll.js:398
Cr @ kbn-ui-shared-deps-npm.dll.js:398
(anonymous) @ kbn-ui-shared-deps-npm.dll.js:398
Re @ kbn-ui-shared-deps-npm.dll.js:398
(anonymous) @ kbn-ui-shared-deps-npm.dll.js:398
Rr @ kbn-ui-shared-deps-npm.dll.js:398
en @ kbn-ui-shared-deps-npm.dll.js:398
Jt @ kbn-ui-shared-deps-npm.dll.js:398
t.unstable_runWithPriority @ kbn-ui-shared-deps-npm.dll.js:406
$i @ kbn-ui-shared-deps-npm.dll.js:398
Ie @ kbn-ui-shared-deps-npm.dll.js:398
Zt @ kbn-ui-shared-deps-npm.dll.js:398

Panel loading infinitely -

[elasticmachine]

Pinging @elastic/kibana-visualizations @elastic/kibana-visualizations-external (Team:Visualizations)

[bhavyarm]

If you navigate away from this dashboard to dashboard listing page - you see the warning - about unsaved changes(?)

[stratoula]

This doesn't happen only for converted to Lens panels but in general if you create a by value visualization and then make some changes, switch to view mode and discard the embeddable appears with an error.

@elastic/kibana-presentation do you know which could be the problem here?

[ThomThomson]

I think these might be two different bugs - with the one where discarding changes to a by value Lens results in a The timeRange property is required for the given configuration error being more impactful because it happens to all panels, not just ones which have been converted from TSVB to Lens. I've opened #151039 to track that.

Let us fix that one first, then we can figure out what is going on with this infinite loading bug.

[stratoula]

Cool, possibly is the same root!

[bhavyarm]

The same bug when you click on newly available reset action.

reset_does_infinite_loading.mp4

[Heenawter]

Verified that this is still happening on 8.11 - this should be resolved by the embeddable refactor initiative (#167429) because an embeddable type change should no longer require an object to be destroyed/recreated.

[stratoula]

Another occurence of the bug. This time when cancelling from the flyout. This is happening when the Defer loading panels before the fold settings are on. When I restored them to the default values, Cancel works as expected!

[bhavyarm]

Still happening in 8.13.0. I converted a TSVB viz to lens viz but choose to switch to view mode without saving option. Kibana displays this error -

and in the browser console:

Uncaught (in promise) TypeError: Cannot read properties of undefined (reading 'getExplicitInputIsEqual')
    at dashboard.chunk.5.js:1:91076

[TomonoriSoejima]

Another case I can run into is when we did import the dashboard using compatibilityMode=true, this error Embeddable has been destroyed showed up in Console log and dashboard stopped loading.

curl -X POST "http://localhost:5601/api/saved_objects/_import?overwrite=true&compatibilityMode=true" -H "kbn-xsrf: true" --form [email protected]