Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Security Solution] Fix workarounds for migrating from rule-level notifyWhen/throttle to action-level #148414

Closed
Zacqary opened this issue Jan 4, 2023 · 3 comments
Closed

[Security Solution] Fix workarounds for migrating from rule-level notifyWhen/throttle to action-level #148414

Zacqary opened this issue Jan 4, 2023 · 3 comments
Assignees
@e40pud
Labels
8.8 candidate Team:Detection Alerts Security Detection Alerts Area Team Team:Detections and Resp Security Detection Response Team Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. technical debt Improvement of the software architecture and operational architecture

Comments

@Zacqary
Copy link
Contributor

Zacqary commented Jan 4, 2023

#145637 deprecates the rule-level notifyWhen and throttle properties in alerts, in favor of including these in an action-level frequency. However, security solution APIs and UIs still use the rule-level parameters, and don't include frequency in the API contract.

#145637 includes a few workarounds marked with TODO and this issue URL. These workarounds should be removed as the security solution migrates to action-level frequency and away from rule-level notifyWhen/throttle.
@Zacqary Zacqary added technical debt Improvement of the software architecture and operational architecture Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. labels Jan 4, 2023
@elasticmachine
Copy link
Contributor

Pinging @elastic/security-solution (Team: SecuritySolution)

@Zacqary Zacqary mentioned this issue Jan 9, 2023
Merged
2 tasks
@XavierM XavierM mentioned this issue Feb 22, 2023
Closed
19 tasks
@banderror banderror added Team:Detections and Resp Security Detection Response Team Team:Detection Alerts Security Detection Alerts Area Team labels Mar 21, 2023
@elasticmachine
Copy link
Contributor

Pinging @elastic/security-detections-response (Team:Detections and Resp)

This was referenced Apr 6, 2023
Closed
Closed
@e40pud
Copy link
Contributor

e40pud commented Apr 23, 2023

Done by #154532 in these PR #154990

@e40pud e40pud closed this as completed Apr 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@e40pud e40pud

Labels
8.8 candidate Team:Detection Alerts Security Detection Alerts Area Team Team:Detections and Resp Security Detection Response Team Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. technical debt Improvement of the software architecture and operational architecture
Projects
None yet
Milestone
No milestone
4 participants
@Zacqary @e40pud @banderror @elasticmachine