Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Security Solution] Error occurs and unable to close the all alerts when edit the exception from rule details page #146661

Closed
ghost opened this issue Nov 30, 2022 · 5 comments · Fixed by #146805
Closed

[Security Solution] Error occurs and unable to close the all alerts when edit the exception from rule details page #146661

ghost opened this issue Nov 30, 2022 · 5 comments · Fixed by #146805
Assignees
@peluja1012 @dhurley14 @nkhristinin
Labels
bug Fixes for quality problems that affect the customer experience Feature:Rule Exceptions Security Solution Detection Rule Exceptions area fixed impact:high Addressing this issue will have a high level of impact on the quality/strength of our product. QA:Validated Issue has been validated by QA Team:Detections and Resp Security Detection Response Team Team:Security Solution Platform Security Solution Platform Team Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. v8.6.0

Comments

@ghost
Copy link

ghost commented Nov 30, 2022

Describe the bug
Error occurs and unable to close the all alerts when edit the exception from rule details page

Build info

Version: 8.6.0 BC4
BUILD: 58612
COMMIT: 218162f282314db5b3833c84752dd24395949b3f

Preconditions

  • Kibana should be running
  • Exception should be created

Steps to Reproduce

  • Navigate to Security > Rules details page
  • Click on exception tab
  • Edit the exception tab
  • Select the Click all alerts check box and update the exception
  • Observe that error occurs and unable to close the all alerts when edit the exception from rule details page

Actual Result

  • Error occurs and unable to close the all alerts when edit the exception from rule details page

Expected Result

  • Error should not be occurred and able to close the all alerts when edit the exception from rule details page

Screen-cast

RuleException.mp4
@ghost ghost added bug Fixes for quality problems that affect the customer experience triage_needed impact:high Addressing this issue will have a high level of impact on the quality/strength of our product. Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. v8.6.0 labels Nov 30, 2022
@elasticmachine
Copy link
Contributor

Pinging @elastic/security-solution (Team: SecuritySolution)

@ghost
Copy link
Author

ghost commented Nov 30, 2022

@karanbirsingh-qasource Please review!!

@ghost ghost assigned MadameSheema Nov 30, 2022
@MadameSheema MadameSheema added the Team:Detections and Resp Security Detection Response Team label Nov 30, 2022
@elasticmachine
Copy link
Contributor

Pinging @elastic/security-detections-response (Team:Detections and Resp)

@MadameSheema MadameSheema added the Team:Security Solution Platform Security Solution Platform Team label Nov 30, 2022
@nkhristinin nkhristinin self-assigned this Nov 30, 2022
@peluja1012 peluja1012 added Feature:Rule Exceptions Security Solution Detection Rule Exceptions area and removed triage_needed labels Nov 30, 2022
@rlapond
Copy link

rlapond commented Dec 1, 2022

Hi,

I think we hit the same issue on 8.5.0, the error is a bit different:
"Error: Error fetching exception list"

We follow the same steps in the video, but in our case the rule exception window doesn't close.

@nkhristinin nkhristinin mentioned this issue Dec 2, 2022
Merged
nkhristinin added a commit that referenced this issue Dec 5, 2022
@nkhristinin @kibanamachine
Remove id from item list (#146805)
7261175 
## Remove id from item list when try to close alerts during update
exceptions
close: #146661

Co-authored-by: Kibana Machine <[email protected]>
kibanamachine pushed a commit to kibanamachine/kibana that referenced this issue Dec 5, 2022
@nkhristinin
Remove id from item list (elastic#146805)
d1da8e6 
## Remove id from item list when try to close alerts during update
exceptions
close: elastic#146661

Co-authored-by: Kibana Machine <[email protected]>
(cherry picked from commit 7261175)
kibanamachine referenced this issue Dec 5, 2022
@kibanamachine @nkhristinin
[8.6] Remove id from item list (#146805) (#147033)
9b8e563 
# Backport

This will backport the following commits from `main` to `8.6`:
- [Remove id from item list
(#146805)](#146805)

<!--- Backport version: 8.9.7 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Khristinin
Nikita","email":"[email protected]"},"sourceCommit":{"committedDate":"2022-12-05T18:01:02Z","message":"Remove
id from item list (#146805)\n\n## Remove id from item list when try to
close alerts during update\r\nexceptions\r\nclose:
https://github.com/elastic/kibana/issues/146661\r\n\r\nCo-authored-by:
Kibana Machine
<[email protected]>","sha":"7261175571b0bcfd68c538067c60eac12dad84e1","branchLabelMapping":{"^v8.7.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:fix","backport:prev-minor","v8.7.0"],"number":146805,"url":"https://github.com/elastic/kibana/pull/146805","mergeCommit":{"message":"Remove
id from item list (#146805)\n\n## Remove id from item list when try to
close alerts during update\r\nexceptions\r\nclose:
https://github.com/elastic/kibana/issues/146661\r\n\r\nCo-authored-by:
Kibana Machine
<[email protected]>","sha":"7261175571b0bcfd68c538067c60eac12dad84e1"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v8.7.0","labelRegex":"^v8.7.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/146805","number":146805,"mergeCommit":{"message":"Remove
id from item list (#146805)\n\n## Remove id from item list when try to
close alerts during update\r\nexceptions\r\nclose:
https://github.com/elastic/kibana/issues/146661\r\n\r\nCo-authored-by:
Kibana Machine
<[email protected]>","sha":"7261175571b0bcfd68c538067c60eac12dad84e1"}}]}]
BACKPORT-->

Co-authored-by: Khristinin Nikita <[email protected]>
@ghost
Copy link
Author

ghost commented Dec 13, 2022

Hi Team,

We have validated this issue on 8.6.0-BC6 build and observed that the issue is fixed.

Please find below the testing details:

Build Details:
VERSION: 8.6.0-BC6
BUILD: 58740
COMMIT: f329a77

Screen-Recording:

close.alerts.mp4

Hence, closing this issue and marking it as QA Validated.

Thanks!

@ghost ghost added the QA:Validated Issue has been validated by QA label Dec 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@peluja1012 peluja1012

@dhurley14 dhurley14

@nkhristinin nkhristinin

Labels
bug Fixes for quality problems that affect the customer experience Feature:Rule Exceptions Security Solution Detection Rule Exceptions area fixed impact:high Addressing this issue will have a high level of impact on the quality/strength of our product. QA:Validated Issue has been validated by QA Team:Detections and Resp Security Detection Response Team Team:Security Solution Platform Security Solution Platform Team Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. v8.6.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove id from item list nkhristinin/kibana
6 participants
@peluja1012 @dhurley14 @nkhristinin @elasticmachine @MadameSheema @rlapond