Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Location of built source code in plugins #14530

Closed
kimjoar opened this issue Oct 24, 2017 · 1 comment
Closed

Location of built source code in plugins #14530

kimjoar opened this issue Oct 24, 2017 · 1 comment
Labels
Feature:New Platform Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc

Comments

@kimjoar
Copy link
Contributor

kimjoar commented Oct 24, 2017

[placeholder — needs more details]

For core plugins and xpack I expect we'll have the source at the root (e.g. in src/), then the built JS in target/something. E.g. in my build exploration PR (#14333) the TypeScript gets built into target/tsc.

However, for pre-built plugins, do we want to require the same?

@kimjoar kimjoar added Feature:New Platform Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc labels Oct 24, 2017
@epixa
Copy link
Contributor

epixa commented Oct 24, 2017

This is for development, right? In that case, I think we should put them inside a top level dev directory. This is getting close to the problems I wanted to address with a new directory structure overall, as I don't think this sort of question should really be hard to answer: #12466

@kimjoar kimjoar closed this as completed Jan 22, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature:New Platform Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc
Projects
None yet
Development

No branches or pull requests

2 participants