Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stack Rules Bulk enable/disable options are overly restricted #144620

Closed
EricDavisX opened this issue Nov 4, 2022 · 3 comments
Closed

Stack Rules Bulk enable/disable options are overly restricted #144620

EricDavisX opened this issue Nov 4, 2022 · 3 comments
Assignees
Labels
bug Fixes for quality problems that affect the customer experience Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams) UX

Comments

@EricDavisX
Copy link
Contributor

Kibana version: 8.6.0-snapshot, kibana commit: 3f62042, issue is the same in 8.5.0 GA

Original install method (e.g. download page, yum, from source, etc.):
Tested on cloud-deploy to staging

Describe the bug:
When you are bulk selecting Stack Rules, the enable / disable options are overly restrictive as to what is shown to the user - if you have a mixed-cases of some rules that are enabled and some that are disabled, it only allows you to disable them. why not let users enable them in this case too?

Steps to reproduce:

  1. create a bunch of stack rules
  2. in Rules page enable at least 1 but not all of them
  3. then select the current page set of rules and try to Enable them - it is not available in the list
    This will likely be more impactful or seen as oddly or inappropriately restrictive UX in light of coming bulk enable/disable rules work with 'select all' at play.

Expected behavior:
User can enabled a mixed-status set of rules, and disable them as well - regardless of state.

Screenshots (if relevant):
Mixed-state-only-disabled-is-shown

Showing that there is some logic in place here, if you only have selected 'Disabled' rules, then the 'Enable' option certainly shows in the UI and works:
Rules-all-Disabled-and-enable-is-shown

@EricDavisX EricDavisX added bug Fixes for quality problems that affect the customer experience UX Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams) labels Nov 4, 2022
@elasticmachine
Copy link
Contributor

Pinging @elastic/response-ops (Team:ResponseOps)

@mdefazio
Copy link
Contributor

mdefazio commented Nov 4, 2022

Thanks for bringing this up @EricDavisX .

Here's a proposed update to the UI:
image

Summary of edits:

  • Popover buttons should be consistent with the Row action popover (EuiContextMenu)
  • Segment snooze, other actions and delete into 3 sections in the popover
  • If we're using the context menu, then 'snooze now' can be similar to how its done for the row actions (as a second panel)
  • I'm good with the modal for schedule snooze actions. just a small edit on the button placement and button labels.

This bulk action component needs some more guidelines to be sure, as it's used a bit randomly. That said, the 'Select all x rules' option shouldn't be shown unless the user selects all items on the page. Not as necessary as the others, but we might as well try and determine the best practices for this component.

@XavierM XavierM moved this from Awaiting Triage to In Progress in AppEx: ResponseOps - Rules & Alerts Management Nov 17, 2022
Repository owner moved this from In Progress to Done in AppEx: ResponseOps - Rules & Alerts Management Dec 20, 2022
@guskovaue
Copy link
Contributor

Was done in this PR: #145928

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Fixes for quality problems that affect the customer experience Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams) UX
Projects
No open projects
Development

No branches or pull requests

4 participants