Grant access to selected Items in listing pages to plugins

[danwhitacre]

Describe the feature:
In dashboard_listing.js and visualize_listing.js, the currently selected items are stored locally to the controller. To get the currently selected items from outside the controller (ie if I am trying to extend the controller as part of my plugin) it requires a wrapper function to iterate through all the items and check if each one is currently selected. Would be nice if there was just a function to get the currently selected items.

currently I do this to get all the currently selected items.

this.getSelectedItems = () => {
    return _.filter(this.items, this.isItemChecked);
};

when in the controller it should just be this:

this.getSelectedItems = () => {
  return selectedItems;
}

[danwhitacre]

I guess in the controller it would look more like this:

this.getSelectedItems = function getSelectedItems() {
  return selectedItems;
};

[stacey-gammon]

We have some big changes coming in this files. Actually, I just submitted a large change so that selectedItems is no longer part of the controller at all, but a part of an internal react listing table component. I plan to do something similar with dashboards.

This will also likely change as we want to introduce some high order react components to extract out the sorting logic.

There is a lot of work going on to explore how to expose a stable plugin API. Check out some of the issues tagged with :platform to see what's going on. Here is one such meta issue about plugins in the new platform system: #12468

[epixa]

@stacey-gammon Given the changes you describe, is this issue still relevant?

[stacey-gammon]

Not relevant, selectedItems is no longer on the controller in visualize, and dashboard will be following suit shortly. If there is anything else we can do, let us know @danwhitacre. I'll go ahead and close for now.

[danwhitacre]

@stacey-gammon Nope all is good. I have the workaround I posted above for anybody stuck on older versions.