-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SavedObjectTagging] Expose flyout to assign tags to a SO #143746
Comments
Pinging @elastic/kibana-core (Team:Core) |
As discussed on slack:
Yea, the assignment works the other way atm. We would need to develop a new flyout to handle the other scenario (selecting objects -> assign tags). FWIW this was initially planned to be developed for the SO management section, but we eventually abandoned the idea. Unless I missed something, nothing is really blocking technically regarding the actual flyout implementation. Now, regarding how this feature should be accessible / usage from elsewhere than the SO tagging management section: The options would be:
kibana/x-pack/plugins/saved_objects_tagging/public/components/assign_flyout/open_assign_flyout.tsx Lines 42 to 50 in 3730dd0
Notes:
kibana/src/plugins/saved_objects_tagging_oss/kibana.json Lines 10 to 11 in 5d9b9a1
So having to depend on this plugin from anywhere else in Kibana seems fairly acceptable. Given that, I would personally go with option 1., as it seems like the better developer experience. But I'm of course open to discussion on that. |
As part of the UX enhancement of the
<TableListView />
we want to allow the user to select one or multiple saved object and assign tags to them in bulk.This is the design proposal for the tag assignment
Feature request
Ideally we would have a package exposing the above flyout to assign tags to one or multiple saved objects passed to it. The package would expose a
KibanaProvider
to pass the stateful dependencies (like thesavedObjectsTagging
plugin).Note:
The current tag assignment in the tag management app has the opposite behaviour: select one or multiple tags ---> assign saved objects to them.
The text was updated successfully, but these errors were encountered: