Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Unified search]- line details expand query editor and SQL reference missing dark theme #142672

Closed
bhavyarm opened this issue Oct 4, 2022 · 4 comments · Fixed by #142703
Closed

[Unified search]- line details expand query editor and SQL reference missing dark theme #142672

bhavyarm opened this issue Oct 4, 2022 · 4 comments · Fixed by #142703
Assignees
@stratoula
Labels
bug Fixes for quality problems that affect the customer experience Feature:Unified search Unified search related tasks impact:low Addressing this issue will have a low level of impact on the quality/strength of our product.

Comments

@bhavyarm
Copy link
Contributor

bhavyarm commented Oct 4, 2022

Kibana version: 8.5.0 BC2

Elasticsearch version: 8.5.0 BC2

Server OS version: darwin_x86_64

Browser version: chrome latest

Browser OS version: OS X

Original install method (e.g. download page, yum, from source, etc.): from staging

Describe the bug: When user switches to SQL in dark theme line details, expand query editor and SQL reference are missing dark theme.

Screen Shot 2022-10-04 at 5 19 51 PM
@bhavyarm bhavyarm added bug Fixes for quality problems that affect the customer experience Team:Visualizations Visualization editors, elastic-charts and infrastructure Feature:Unified search Unified search related tasks labels Oct 4, 2022
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-vis-editors @elastic/kibana-vis-editors-external (Team:VisEditors)

@stratoula stratoula added impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. Team:AppServicesSv and removed Team:Visualizations Visualization editors, elastic-charts and infrastructure labels Oct 5, 2022
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app-services (Team:AppServicesSv)

@stratoula
Copy link
Contributor

@MichaelMarcialis about the expand and documentation buttons it is clear how to fix it but about the line badge I am not sure. I am using the color="default", should I use a different color for the dark mode?

@MichaelMarcialis
Copy link
Contributor

@MichaelMarcialis about the expand and documentation buttons it is clear how to fix it but about the line badge I am not sure. I am using the color="default", should I use a different color for the dark mode?

Hey, @stratoula. It looks like we use $euiFormInputGroupLabelBackground for the form prepend/append background color in EUI, which I confirmed does have a dark mode counterpart. Let me know if works.

@stratoula stratoula changed the title SQL - line details expand query editor and SQL reference missing dark theme [Unified search]- line details expand query editor and SQL reference missing dark theme Oct 6, 2022
@stratoula stratoula self-assigned this Oct 6, 2022
@stratoula stratoula mentioned this issue Oct 6, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@stratoula stratoula

Labels
bug Fixes for quality problems that affect the customer experience Feature:Unified search Unified search related tasks impact:low Addressing this issue will have a low level of impact on the quality/strength of our product.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[Unified search] Fixes the ui on the dark mode stratoula/kibana
4 participants
@MichaelMarcialis @bhavyarm @elasticmachine @stratoula