Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename appState.vis to appState.visState #14189

Closed
thomasneirynck opened this issue Sep 27, 2017 · 1 comment
Closed

Rename appState.vis to appState.visState #14189

thomasneirynck opened this issue Sep 27, 2017 · 1 comment
Assignees
@thomasneirynck
Labels
chore Feature:Visualizations Generic visualization features (in case no more specific feature label is available) PR sent Team:Visualizations Visualization editors, elastic-charts and infrastructure

Comments

@thomasneirynck
Copy link
Contributor

.vis is in this case not the vis-object, but instead the visState. This is confusing, especially since the vis object is now documented API
@thomasneirynck thomasneirynck added Feature:Visualizations Generic visualization features (in case no more specific feature label is available) chore v6.0.0 labels Sep 27, 2017
This was referenced Sep 27, 2017
Closed
Closed
@thomasneirynck thomasneirynck self-assigned this Oct 24, 2017
@timroes timroes added the Team:Visualizations Visualization editors, elastic-charts and infrastructure label Sep 16, 2018
@timroes
Copy link
Contributor

timroes commented Oct 27, 2018

I think with the new editor we might want to rethink what to store in the URL anyway, and it seems the renaming PR got stalled that time. Also vis won't exist in that form in the new pipeline anymore, so this issue might have outlived itself :-) Thus I'll be closing it for now, since we don't have intermediate intentions to rename that parameter before the new expression language.

@timroes timroes closed this as completed Oct 27, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@thomasneirynck thomasneirynck

Labels
chore Feature:Visualizations Generic visualization features (in case no more specific feature label is available) PR sent Team:Visualizations Visualization editors, elastic-charts and infrastructure
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@timroes @thomasneirynck