Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Actionable Observability] Update an SLO #141283

Closed
2 tasks
Tracked by #137323
kdelemme opened this issue Sep 21, 2022 · 1 comment
Closed
2 tasks
Tracked by #137323

[Actionable Observability] Update an SLO #141283

kdelemme opened this issue Sep 21, 2022 · 1 comment
Assignees
Labels
Team: Actionable Observability - DEPRECATED For Observability Alerting and SLOs use "Team:obs-ux-management", for AIops "Team:obs-knowledge" v8.6.0

Comments

@kdelemme
Copy link
Contributor

kdelemme commented Sep 21, 2022

📝 Summary

Part of #137323
RFC

A user should be able to edit any existing SLO and change any fields from it.

As detailed in the RFC, when any properties but the indicator is updated on an SLO, the system will simply update the SLO saved object without introducing a new revision. In this case, the related transform does not need to be updated and the aggregated data is still valid.

When the indicator changes, the transform becomes invalid and the previously aggregated data too. In this case, we need to:

  1. Bump the SLO revision
  2. Update the SLO saved object
  3. Stop and Remove the previously running transform: slo-{slo.id}-{slo.previous_revision}
  4. Delete (asynchronously) the previously aggregated data using es deleteByQuery with (slo.id, slo.previous_revision)
  5. Create and Start the new transform: slo-{slo.id}-{slo.revision}

✅ Acceptance Criteria

  • Updating any fields but indicator, should only update the slo saved object
  • Updating the indicator, should bump the slo revision, create a new transform and remove previous data
@botelastic botelastic bot added the needs-team Issues missing a team label label Sep 21, 2022
@kdelemme kdelemme added Team: Actionable Observability - DEPRECATED For Observability Alerting and SLOs use "Team:obs-ux-management", for AIops "Team:obs-knowledge" and removed needs-team Issues missing a team label labels Sep 21, 2022
@elasticmachine
Copy link
Contributor

Pinging @elastic/actionable-observability (Team: Actionable Observability)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Team: Actionable Observability - DEPRECATED For Observability Alerting and SLOs use "Team:obs-ux-management", for AIops "Team:obs-knowledge" v8.6.0
Projects
None yet
Development

No branches or pull requests

2 participants