Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Lens] standardize references between columns #141125

Open
drewdaemon opened this issue Sep 20, 2022 · 1 comment
Open

[Lens] standardize references between columns #141125

drewdaemon opened this issue Sep 20, 2022 · 1 comment
Labels
Feature:Lens impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. loe:needs-research This issue requires some research before it can be worked on or estimated Team:Visualizations Visualization editors, elastic-charts and infrastructure

Comments

@drewdaemon
Copy link
Contributor

Background
Today, referenced columns in the indexpattern datasource are always intermediary columns that are used "under the hood." If we conceptualize the columns as a graph with the columns being the nodes and the references being the edges, they form a series of DAG trees, the top level columns that are directly used in the visualization being the roots.

No references exist between trees except for one: sort-by in the top values function. In the code, this reference is not modeled in the same way as the others.

We could standardize how references are represented in the code to provide an easy and consistent way to understand and change which columns reference each other. One option is to follow the pattern of saved object references and store all column references in a list.

Describe a specific use case for the feature:
If we standardized the way all references between columns are represented we would unlock

@drewdaemon drewdaemon added Team:Visualizations Visualization editors, elastic-charts and infrastructure Feature:Lens labels Sep 20, 2022
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-vis-editors @elastic/kibana-vis-editors-external (Team:VisEditors)

@drewdaemon drewdaemon added loe:needs-research This issue requires some research before it can be worked on or estimated impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. labels Dec 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature:Lens impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. loe:needs-research This issue requires some research before it can be worked on or estimated Team:Visualizations Visualization editors, elastic-charts and infrastructure
Projects
None yet
Development

No branches or pull requests

2 participants