Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Embeddable] Review extension points #140411

Closed
dokmic opened this issue Sep 9, 2022 · 4 comments
Closed

[Embeddable] Review extension points #140411

dokmic opened this issue Sep 9, 2022 · 4 comments
Labels
Feature:Embeddables Relating to the Embeddable system impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. loe:medium Medium Level of Effort Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas

Comments

@dokmic
Copy link
Contributor

dokmic commented Sep 9, 2022

Background

Sometimes, we add new functionality by adding new stuff directly to the embeddable interface. But sometimes, we create special-purpose interfaces like SelfStyledEmbeddable or FilterableEmbeddable.
We should define a recommended way of extending the base embeddable class.

Proposal

  • Review the main embeddable interface and highlight all the methods/properties that might be moved to separate interfaces to simplify the main interface.
  • Check the references to the highlighted methods and determine if they can be easily moved out of the main embeddable class and interface.
  • Try to extract the implementation of those methods using a mixin pattern in TypeScript.
  • The goal is to follow the interface segregation principle, as overcomplicating code was never a good solution.
@dokmic dokmic added Feature:Embedding Embedding content via iFrame loe:medium Medium Level of Effort impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. Team:AppServicesUx labels Sep 9, 2022
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app-services (Team:AppServicesUx)

@dokmic dokmic mentioned this issue Sep 9, 2022
Closed
8 tasks
@petrklapka petrklapka added Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas and removed Team:AppServicesUx labels Dec 12, 2022
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-presentation (Team:Presentation)

@ThomThomson
Copy link
Contributor

Keeping this one open and adding it to our backlog. Would be great to do this audit.

@ThomThomson ThomThomson added Feature:Embeddables Relating to the Embeddable system and removed Feature:Embedding Embedding content via iFrame labels Jun 14, 2023
@ThomThomson
Copy link
Contributor

Closing this in favour of the Embeddables Rebuild initiative.

@ThomThomson ThomThomson closed this as not planned Won't fix, can't repro, duplicate, stale Sep 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Feature:Embeddables Relating to the Embeddable system impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. loe:medium Medium Level of Effort Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@ThomThomson @dokmic @elasticmachine @petrklapka