Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Embeddable] Refactor Embeddable Panel Components #140408

Closed
Tracked by #144752
dokmic opened this issue Sep 9, 2022 · 2 comments · Fixed by #159837
Closed
Tracked by #144752

[Embeddable] Refactor Embeddable Panel Components #140408

dokmic opened this issue Sep 9, 2022 · 2 comments · Fixed by #159837
Assignees
@ThomThomson
Labels
Feature:Embeddables Relating to the Embeddable system impact:medium Addressing this issue will have a medium level of impact on the quality/strength of our product. loe:medium Medium Level of Effort Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas

Comments

@dokmic
Copy link
Contributor

dokmic commented Sep 9, 2022

Background

To make the loading state easier to handle, the embeddable panel and embeddable child panel components should be refactored/combined.

Proposal

Review all the React components exported by the embeddables plugin and check all the references to them in the code. The goal will be to refactor the components so they can be used without needing to write a Higher-Order Component.
@dokmic dokmic added Feature:Embedding Embedding content via iFrame loe:medium Medium Level of Effort impact:medium Addressing this issue will have a medium level of impact on the quality/strength of our product. Team:AppServicesUx labels Sep 9, 2022
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app-services (Team:AppServicesUx)

This was referenced Sep 9, 2022
Closed
Closed
@petrklapka petrklapka added Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas and removed Team:AppServicesUx labels Dec 12, 2022
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-presentation (Team:Presentation)

@ThomThomson ThomThomson changed the title [Embeddable] React components refactoring [Embeddable] Refactor Panel React Components Jan 12, 2023
@ThomThomson ThomThomson changed the title [Embeddable] Refactor Panel React Components [Embeddable] Refactor Embeddable Panel Components Jan 12, 2023
@ThomThomson ThomThomson mentioned this issue Jan 12, 2023
Closed
22 tasks
@cqliu1 cqliu1 mentioned this issue Jan 18, 2023
Closed
18 tasks
@ThomThomson ThomThomson mentioned this issue Apr 12, 2023
Open
24 tasks
@ThomThomson ThomThomson added Feature:Embeddables Relating to the Embeddable system and removed Feature:Embedding Embedding content via iFrame labels Jun 14, 2023
@ThomThomson ThomThomson mentioned this issue Jun 15, 2023
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ThomThomson ThomThomson

Labels
Feature:Embeddables Relating to the Embeddable system impact:medium Addressing this issue will have a medium level of impact on the quality/strength of our product. loe:medium Medium Level of Effort Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[Embeddable] Refactor embeddable panel ThomThomson/kibana
4 participants
@ThomThomson @dokmic @elasticmachine @petrklapka