Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not block dashboard SO loading on default data view loading #140243

Closed
flash1293 opened this issue Sep 8, 2022 · 1 comment · Fixed by #144332
Closed

Do not block dashboard SO loading on default data view loading #140243

flash1293 opened this issue Sep 8, 2022 · 1 comment · Fixed by #144332
Labels
Feature:Dashboard Dashboard related features impact:high Addressing this issue will have a high level of impact on the quality/strength of our product. loe:small Small Level of Effort performance Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas

Comments

@flash1293
Copy link
Contributor

flash1293 commented Sep 8, 2022

In

const isEmpty = await isDashboardAppInNoDataState(dataViews);

and

const defaultDataView = await dataViews.getDefaultDataView();

first, the request is done to check whether there is data. Then, the default data view is loaded to check whether a default data view exists. Only afterwards the dashboard saved object is loaded. The data view loading is two roundtrips to Elasticsearch. The dashboard SO loading is one roundtrip to Elasticsearch. Loading these three things in parallel would save at least two roundtrips and speed up the time to meaningful render.

@flash1293 flash1293 added the Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas label Sep 8, 2022
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-presentation (Team:Presentation)

@ThomThomson ThomThomson added Feature:Dashboard Dashboard related features loe:small Small Level of Effort impact:high Addressing this issue will have a high level of impact on the quality/strength of our product. labels Sep 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature:Dashboard Dashboard related features impact:high Addressing this issue will have a high level of impact on the quality/strength of our product. loe:small Small Level of Effort performance Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants