Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Default query language in app state to match linked search if there is one #14016

Closed
Bargs opened this issue Sep 15, 2017 · 1 comment
Closed
Labels
bug Fixes for quality problems that affect the customer experience Feature:Visualizations Generic visualization features (in case no more specific feature label is available)

Comments

@Bargs
Copy link
Contributor

Bargs commented Sep 15, 2017

When creating new filters, filter_bar_click_handler looks at the app state to see which language it should use. In Visualize, when a visualization is linked to a saved search, that saved search's query is separate from the one in app state. This means that filter_bar_click_handler might use the wrong language if, for instance, the saved search is lucene but the default language (in app state) is kuery. When a saved search is linked, we should ignore the global default and set the app state language to whatever the saved search is using.

@Bargs Bargs added :Discovery Feature:Visualizations Generic visualization features (in case no more specific feature label is available) bug Fixes for quality problems that affect the customer experience labels Sep 15, 2017
@Bargs
Copy link
Contributor Author

Bargs commented Oct 4, 2017

No longer necessary now that #14212 is merged

@Bargs Bargs closed this as completed Oct 4, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Fixes for quality problems that affect the customer experience Feature:Visualizations Generic visualization features (in case no more specific feature label is available)
Projects
None yet
Development

No branches or pull requests

1 participant