Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[meta][shared-ux] Follow up to EUI v63.x upgrade #140118

Closed
2 tasks
cee-chen opened this issue Sep 6, 2022 · 1 comment · Fixed by #141043
Closed
2 tasks

[meta][shared-ux] Follow up to EUI v63.x upgrade #140118

cee-chen opened this issue Sep 6, 2022 · 1 comment · Fixed by #141043
Assignees
@majagrubic
Labels
Team:SharedUX Team label for AppEx-SharedUX (formerly Global Experience)

Comments

@cee-chen
Copy link
Contributor

cee-chen commented Sep 6, 2022

Follow-up various TODOs added by Caroline in the EUI upgrade that makes breaking changes to EuiPageTemplate and KibanaPageTemplate: #139524

@clintandrewhall feel free to take over this issue or close it and open a new one if you prefer! Again, apologies that I couldn't help more with the TODOs, as I don't fully have context for what Caroline's goals were with them. Please feel free to ping me with any questions or if I can help down the road however!
@cee-chen cee-chen added the Team:SharedUX Team label for AppEx-SharedUX (formerly Global Experience) label Sep 6, 2022
@cee-chen
Copy link
Contributor Author

cee-chen commented Sep 6, 2022

Also worth mentioning: please see some of Caroline's original PR comments here:

#138546 (review)

@cee-chen cee-chen mentioned this issue Sep 6, 2022
Merged
@majagrubic majagrubic mentioned this issue Sep 20, 2022
Merged
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@majagrubic majagrubic

Labels
Team:SharedUX Team label for AppEx-SharedUX (formerly Global Experience)
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[SharedUX] Removing TODOs from KibanaPageTemplate majagrubic/kibana
3 participants
@clintandrewhall @cee-chen @majagrubic