Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Observability] UI regressions from EuiPageTemplate component upgrade #139893

Closed
4 tasks done
formgeist opened this issue Sep 1, 2022 · 5 comments
Closed
4 tasks done
Labels
Meta Team:Observability Team label for Observability Team (for things that are handled across all of observability)

Comments

@formgeist
Copy link
Contributor

formgeist commented Sep 1, 2022

Summary

Related PR #139524

This meta issue is simply tracking the regressions found in the Observability UI that will need to be fixed either before this PR merges or after. I've asked for the best way forward on that.

Regressions

Review in progress, so this list is not final

General

Logs app

  • Logs component is not displaying at full page height
View screens

CleanShot 2022-09-01 at 10 06 47@2x

  • Loading and empty states are not vertically centered
View screens

localhost_5601_bmc_app_logs_stream_flyoutOptions=(flyoutId_!n,flyoutVisibility_hidden,surroundingLogsId_!n) logPosition=(end_now,position_(tiebreaker_16499,time_1662019454823),start_now-1d,streamLive_!f) (1)

CleanShot 2022-09-01 at 10 06 54@2x

Infrastructure app

View screens

CleanShot 2022-09-01 at 10 15 39@2x

UX app

  • Observability side navigation disappears when visiting the UX app
View screens

localhost_5601_bmc_app_ux_rangeFrom=now-15m rangeTo=now percentile=50 serviceName=elastic-co-frontend

@formgeist formgeist added Meta Team:Observability Team label for Observability Team (for things that are handled across all of observability) labels Sep 1, 2022
@elasticmachine
Copy link
Contributor

Pinging @elastic/unified-observability (Team:Observability)

@cee-chen
Copy link
Contributor

cee-chen commented Sep 1, 2022

I think I should have addressed the majority of these in my recent commits to the EUI PR, except for maybe the Inventory padding (since I'm a total o11y noob and I don't know how to get my local set up with valid data 🙈). Would love to pair with you next week if you're open to it!

Please continue QAing/pointing out more issues! Thanks so much for catching these! 🙏

@formgeist
Copy link
Contributor Author

@constancecchen Thanks for already resolving the worst of the bunch 👍 I'm fine with opening whatever remains as separate issues that we can handle after the merge of your PR. And thanks for keeping these components up to date - we're just mostly running the old stuff. I'll make sure that the UI dev teams are aware of the deprecations and that they open their own tech debt issues to fix when convenient.

@formgeist
Copy link
Contributor Author

Closing this issue since no other regressions have been found during our testing. I've opened #140002 to follow up on the only remaining issue.

@cee-chen
Copy link
Contributor

cee-chen commented Sep 6, 2022

Sounds great. Thanks a million Casper!! 🙌

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Meta Team:Observability Team label for Observability Team (for things that are handled across all of observability)
Projects
None yet
Development

No branches or pull requests

3 participants