Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Security Solution] Cover prebuilt detection rules upgrade flow with tests #139533

Closed
xcrzx opened this issue Aug 26, 2022 · 3 comments
Closed

[Security Solution] Cover prebuilt detection rules upgrade flow with tests #139533

xcrzx opened this issue Aug 26, 2022 · 3 comments
Assignees
@xcrzx
Labels
8.7 candidate Feature:Prebuilt Detection Rules Security Solution Prebuilt Detection Rules area Team:Detection Rule Management Security Detection Rule Management Team Team:Detections and Resp Security Detection Response Team Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. technical debt Improvement of the software architecture and operational architecture

Comments

@xcrzx
Copy link
Contributor

xcrzx commented Aug 26, 2022 •
edited by banderror
Loading

Given that we had issues with the prebuilt detection rules upgrade flow (#139095, #138876), we need to increase test coverage of that area.

Consider adding e2e and integration tests for the following cases:

  • If installed prebuilt rules are up to date, the upgrade callout should not be visible
  • If a new prebuilt rule version exists, users should see an upgrade callout. After clicking on the upgrade button, rules should be updated, and the callout should disappear.
  • The upgrade behavior should work for both filesystem rules (x-pack/plugins/security_solution/server/lib/detection_engine/rules/prepackaged_rules) and Fleet distributed rules.
@xcrzx xcrzx added technical debt Improvement of the software architecture and operational architecture Team:Detections and Resp Security Detection Response Team Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. Team:Detection Rule Management Security Detection Rule Management Team Feature:Prebuilt Detection Rules Security Solution Prebuilt Detection Rules area labels Aug 26, 2022
@elasticmachine
Copy link
Contributor

Pinging @elastic/security-detections-response (Team:Detections and Resp)

@elasticmachine
Copy link
Contributor

Pinging @elastic/security-solution (Team: SecuritySolution)

@xcrzx xcrzx mentioned this issue Aug 26, 2022
Merged
@xcrzx
Copy link
Contributor Author

xcrzx commented Jan 13, 2023

Closing in favor of #148176

@xcrzx xcrzx closed this as completed Jan 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@xcrzx xcrzx

Labels
8.7 candidate Feature:Prebuilt Detection Rules Security Solution Prebuilt Detection Rules area Team:Detection Rule Management Security Detection Rule Management Team Team:Detections and Resp Security Detection Response Team Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. technical debt Improvement of the software architecture and operational architecture
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@xcrzx @banderror @elasticmachine