Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clicking on click to enter on two digit numbers make the contents of the cell (lens table) disappear #139137

Closed
bhavyarm opened this issue Aug 18, 2022 · 5 comments · Fixed by #139619
Assignees
Labels
bug Fixes for quality problems that affect the customer experience Feature:Data Table Data table visualization feature Feature:Lens impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. Team:Visualizations Visualization editors, elastic-charts and infrastructure

Comments

@bhavyarm
Copy link
Contributor

Kibana version: 8.4.0 BC4

Elasticsearch version: 8.4.0 BC4

Server OS version: darwin_x86_64

Browser version: chrome latest

Browser OS version: OS X

Original install method (e.g. download page, yum, from source, etc.): from staging

Describe the bug: If you click on icon to interact with cell contents and the value is a two digit number - the action completely covers the contents of the cell.

weird.mp4
@bhavyarm bhavyarm added bug Fixes for quality problems that affect the customer experience Feature:Data Table Data table visualization feature Team:Visualizations Visualization editors, elastic-charts and infrastructure Feature:Lens labels Aug 18, 2022
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-vis-editors @elastic/kibana-vis-editors-external (Team:VisEditors)

@drewdaemon
Copy link
Contributor

drewdaemon commented Aug 18, 2022

Could alleviate the problem by giving the extra actions div a transparent background.

Screen Shot 2022-08-18 at 6 17 02 PM

Single-digit numbers would still be completely obscured, though.

Edit: come to think of it... I think this would be on the EUI side, though we could always override styles from our end.

@flash1293 flash1293 added the impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. label Aug 19, 2022
@flash1293
Copy link
Contributor

This seems very similar to these known issues:
#99312
elastic/eui#5828

However it's slightly different because the cell actions should push out the number, it seems like they stopped doing it at some point. Discover has the same problem, so it's not unique to Lens, but I wonder why the "pushing out" stopped working. @chandlerprall @constancecchen could you have a look at this? Is there something wrong with how Lens and Discover are using the data grid?

@cee-chen
Copy link
Contributor

cee-chen commented Aug 22, 2022

The "pushing out" CSS/effect occurs only on row heights of undefined/"Single" in the UI:

If you are using a row height with a lineCount of 1 ("Custom" in the above popover) or a static height (e.g. 30px), then the cell actions overlap the cell content instead of "pushing" the cell content.

Agreed that elastic/eui#5828 might need to account for this as well.

@flash1293
Copy link
Contributor

OK, let's address this for now by not passing a line count of 1 but undefined to get back the push-out behavior

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Fixes for quality problems that affect the customer experience Feature:Data Table Data table visualization feature Feature:Lens impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. Team:Visualizations Visualization editors, elastic-charts and infrastructure
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants