Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fleet]: User is unable to select Default checkboxes available in Agent Binary Download section under Settings tab. #136504

Closed
amolnater-qasource opened this issue Jul 18, 2022 · 7 comments · Fixed by #136660
Assignees
Labels
bug Fixes for quality problems that affect the customer experience impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. QA:Validated Issue has been validated by QA Team:Fleet Team label for Observability Data Collection Fleet team

Comments

@amolnater-qasource
Copy link

Kibana version: 8.4 Snapshot Kibana cloud environment

Host OS and Browser version: All, All

Build details:

VERSION: 8.4.0
BUILD: 54571
COMMIT: f53c703c4e8851adc51da800a0965eaaae4136fe

Preconditions:

  1. 8.4 Snapshot Kibana cloud environment should be available.

Steps to reproduce:

  1. Navigate to Fleet>Settings tab.
  2. Click Add agent binary source under Agent Binary Download.
  3. Add name: Test and add required url and click Save and apply settings.
  4. Similarly, add multiple Sources.
  5. Click on checkboxes and observe user is unable to click available checkboxes.

Expected Result:
Other checkboxes other than Default checkbox should be disabled or should be able to manage Default source with checkbox.
OR
Checkboxes should be replaced with badge as available under Output settings.
image

Screen Recording:

Settings.-.Fleet.-.Elastic.-.Google.Chrome.2022-07-18.14-29-47.mp4
@amolnater-qasource amolnater-qasource added bug Fixes for quality problems that affect the customer experience impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. Team:Fleet Team label for Observability Data Collection Fleet team labels Jul 18, 2022
@elasticmachine
Copy link
Contributor

Pinging @elastic/fleet (Team:Fleet)

@amolnater-qasource
Copy link
Author

@manishgupta-qasource Please review.

@manishgupta-qasource
Copy link

Secondary review for this ticket is Done

@kpollich
Copy link
Member

@amolnater-qasource This is a temporary UI element until we replace it with an icon/badge. The checkbox isn't meant to be selectable, just to indicate that a given download source is configured as the default. If you edit the source via the actions menu, you should be able to update its default status and checkboxes will update to match.

cc @criamico - Can you mark this as closed when the icon/badge is in place here?

@criamico
Copy link
Contributor

@dborodyansky I'm thinking that in this case we could just use an icon to indicate the default:

Screenshot 2022-07-19 at 14 21 38

We could also use a badge but I think it would be weird to duplicate the text "default" on the badge and on the column.
What do you think?

@dborodyansky
Copy link
Contributor

@criamico Yes, if there is only one default designation, a check icon works well, as in your screenshot. When there may be multiple default designations, such as with Outputs, a badge to specify the default would be more suitable.

@amolnater-qasource
Copy link
Author

Hi @criamico
Thank you for the fixes.
We have revalidated this issue on latest 8.4 Snapshot and found it fixed now.

  • Checkboxes are updated with checkmark icon under download sources table.

Build details:
BUILD: 54789
COMMIT: af3a3cb

Screenshot:
12

Hence marking this as QA:Validated.
Thanks

@amolnater-qasource amolnater-qasource added QA:Ready for Testing Code is merged and ready for QA to validate QA:Validated Issue has been validated by QA and removed QA:Ready for Testing Code is merged and ready for QA to validate labels Jul 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Fixes for quality problems that affect the customer experience impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. QA:Validated Issue has been validated by QA Team:Fleet Team label for Observability Data Collection Fleet team
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants