Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Maps] Filter dashboard by map bounds creates duplicate filter pill if filter label is changed #136231

Closed
nickpeihl opened this issue Jul 12, 2022 · 3 comments
Closed

[Maps] Filter dashboard by map bounds creates duplicate filter pill if filter label is changed #136231

nickpeihl opened this issue Jul 12, 2022 · 3 comments
Labels
bug Fixes for quality problems that affect the customer experience Feature:Maps impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas usability

Comments

@nickpeihl
Copy link
Member

Kibana version:
main

Describe the bug:

Related to #107044.

Filter dashboard by map bounds automatically creates a filter pill on the dashboard. If a user changes the label for this filter pill, the filter's meta.controlledBy property is lost. So when the map is moved again, a duplicate filter pill is created.

Steps to reproduce:

  1. Open the ecommerce logs dashboard
  2. On the map panel, enable the Filter dashboard by map bounds option
  3. Edit the filter and change label of the filter pill from geoip.location within map bounds to foobar.
  4. Pan or zoom the map and notice a new filter pill is created

Expected behavior:

When editing the filter label, we should retain the meta.controlledBy property so that the filter is re-used.
@nickpeihl nickpeihl added bug Fixes for quality problems that affect the customer experience [Deprecated-Use Team:Presentation]Team:Geo Former Team Label for Geo Team. Now use Team:Presentation labels Jul 12, 2022
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-gis (Team:Geo)

@teresaalvarezsoler teresaalvarezsoler added usability impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. labels Jul 18, 2022
@petrklapka petrklapka added Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas and removed [Deprecated-Use Team:Presentation]Team:Geo Former Team Label for Geo Team. Now use Team:Presentation labels Nov 3, 2022
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-presentation (Team:Presentation)

@nreese nreese mentioned this issue Feb 7, 2023
Open
@nreese
Copy link
Contributor

nreese commented Apr 5, 2023

Fixed by #154087

@nreese nreese closed this as completed Apr 5, 2023
@nreese nreese mentioned this issue Apr 5, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Fixes for quality problems that affect the customer experience Feature:Maps impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas usability
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
6 participants
@nreese @nickpeihl @jb1b84 @elasticmachine @petrklapka @teresaalvarezsoler