Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Fleet]: On clicking Continue enrolling button under Add Fleet Server flyout, user is redirected to Add agent flyout> Run Standalone #136080

Closed
ghost opened this issue Jul 11, 2022 · 6 comments · Fixed by #136566
Closed

[Fleet]: On clicking Continue enrolling button under Add Fleet Server flyout, user is redirected to Add agent flyout> Run Standalone #136080

ghost opened this issue Jul 11, 2022 · 6 comments · Fixed by #136566
Assignees
@kpollich
Labels
bug Fixes for quality problems that affect the customer experience impact:medium Addressing this issue will have a medium level of impact on the quality/strength of our product. QA:Validated Issue has been validated by QA Team:Fleet Team label for Observability Data Collection Fleet team

Comments

@ghost
Copy link

ghost commented Jul 11, 2022 •
edited by ghost
Loading

Kibana version: 8.4 Snapshot Kibana cloud environment

Host OS and Browser version: All, All

Build details:

VERSION: 8.4 Snapshot
BUILD: 54370
COMMIT: 27befe47a084f7b046426aa3edac01293d6e407b

Preconditions:

  1. 8.4 Snapshot Kibana cloud environment should be available.
  2. Fleet Server policy should be created from Add Fleet Server button.

Steps to reproduce:

  1. Login to Kibana environment.
  2. Navigate to Fleet Agents tab.
  3. Click on Add Fleet Server button.
  4. Click on 'Continue Enrolling elastic agent.'
  5. Observe Run Standalone Flyout appears.

Expected Result:
On clicking Continue enrolling button under Add Fleet Server flyout, user should be redirected to Add agent flyout> Enroll in fleet.

Screen Recording:

Agents.-.Fleet.-.Elastic.-.Google.Chrome.2022-07-11.10-50-11.mp4
@ghost ghost added bug Fixes for quality problems that affect the customer experience impact:medium Addressing this issue will have a medium level of impact on the quality/strength of our product. Team:Fleet Team label for Observability Data Collection Fleet team labels Jul 11, 2022
@elasticmachine
Copy link
Contributor

Pinging @elastic/fleet (Team:Fleet)

@ghost
Copy link
Author

ghost commented Jul 11, 2022

@manishgupta-qasource Please review

@manishgupta-qasource
Copy link

Secondary review for this ticket is Done

@jen-huang
Copy link
Contributor

@kpollich Did we test this flow as part of #135734?

@kpollich
Copy link
Member

We did test this, but I was under the impression stadalone was still the desired tab in this case. Should be a relatively simple fix to default to the Enroll in Fleet tab here. I'll self-assign this.

@kpollich kpollich self-assigned this Jul 12, 2022
kpollich added a commit to kpollich/kibana that referenced this issue Jul 18, 2022
@kpollich
Go to Fleet mode when continue enrolling is selected
b4a335f 
Fixes elastic#136080
@kpollich kpollich mentioned this issue Jul 18, 2022
Merged
kpollich added a commit that referenced this issue Jul 19, 2022
@kpollich
[Fleet] Fleet Server flyout fixes (#136566)
f862943 
* Go to Fleet mode when continue enrolling is selected

Fixes #136080

* Fix max width in Fleet Server flyout

Fixes #136079

* Use fleet mode when fleet server ready, standalone mode otherwise per PR feedback
kibanamachine pushed a commit that referenced this issue Jul 19, 2022
@kpollich
[Fleet] Fleet Server flyout fixes (#136566)
76f195c 
* Go to Fleet mode when continue enrolling is selected

Fixes #136080

* Fix max width in Fleet Server flyout

Fixes #136079

* Use fleet mode when fleet server ready, standalone mode otherwise per PR feedback

(cherry picked from commit f862943)
kibanamachine added a commit that referenced this issue Jul 19, 2022
@kibanamachine @kpollich
[Fleet] Fleet Server flyout fixes (#136566) (#136669)
4741a65 
* Go to Fleet mode when continue enrolling is selected

Fixes #136080

* Fix max width in Fleet Server flyout

Fixes #136079

* Use fleet mode when fleet server ready, standalone mode otherwise per PR feedback

(cherry picked from commit f862943)

Co-authored-by: Kyle Pollich <[email protected]>
@amolnater-qasource amolnater-qasource added the QA:Ready for Testing Code is merged and ready for QA to validate label Jul 21, 2022
@ghost
Copy link
Author

ghost commented Jul 25, 2022

Hi @kpollich
We have revalidated this issue on latest 8.4 Snapshot kibana Cloud environment and found it fixed now.

  • On clicking Continue enrolling button under Add Fleet Server flyout, user is redirected to Add agent flyout> Enroll in fleet.

Build Details:
VERSION: 8.4.0
BUILD: 54789
COMMIT: af3a3cb

Screen Recording:

Agents.-.Fleet.-.Elastic.-.Google.Chrome.2022-07-25.12-01-20.mp4

Hence, marking this as QA:Validated
Thanks

@ghost ghost added QA:Validated Issue has been validated by QA and removed QA:Ready for Testing Code is merged and ready for QA to validate labels Jul 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kpollich kpollich

Labels
bug Fixes for quality problems that affect the customer experience impact:medium Addressing this issue will have a medium level of impact on the quality/strength of our product. QA:Validated Issue has been validated by QA Team:Fleet Team label for Observability Data Collection Fleet team
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[Fleet] Fleet Server flyout fixes kpollich/kibana
5 participants
@jen-huang @kpollich @elasticmachine @manishgupta-qasource @amolnater-qasource