Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Fleet]: UI gets distorted with long fleet server host url under Add fleet server flyout. #136079

Closed
amolnater-qasource opened this issue Jul 11, 2022 · 5 comments · Fixed by #136566
Closed

[Fleet]: UI gets distorted with long fleet server host url under Add fleet server flyout. #136079

amolnater-qasource opened this issue Jul 11, 2022 · 5 comments · Fixed by #136566
Assignees
@kpollich
Labels
bug Fixes for quality problems that affect the customer experience impact:medium Addressing this issue will have a medium level of impact on the quality/strength of our product. QA:Validated Issue has been validated by QA Team:Fleet Team label for Observability Data Collection Fleet team

Comments

@amolnater-qasource
Copy link

Kibana version: 8.4 Snapshot Kibana cloud environment

Host OS and Browser version: All, All

Build details:

VERSION: 8.4.0 Snapshot
BUILD: 54370
COMMIT: 27befe47a084f7b046426aa3edac01293d6e407b

Preconditions:

  1. 8.4 Snapshot Kibana cloud environment should be available.

Steps to reproduce:

  1. Navigate to Fleet>Agents tab.
  2. Click Add fleet server button.
  3. Observe long fleet server host url under Fleet server host field and gets stretched.
  4. Observe dropdown gets distorted on clicking field.

Expected Result:
UI should not get distorted with long fleet server host url under Add fleet server flyout.

Screenshots:
6
5
@amolnater-qasource amolnater-qasource added bug Fixes for quality problems that affect the customer experience impact:medium Addressing this issue will have a medium level of impact on the quality/strength of our product. Team:Fleet Team label for Observability Data Collection Fleet team labels Jul 11, 2022
@elasticmachine
Copy link
Contributor

Pinging @elastic/fleet (Team:Fleet)

@amolnater-qasource
Copy link
Author

@manishgupta-qasource Please review.

@manishgupta-qasource
Copy link

Secondary review for this ticket is Done

@jen-huang
Copy link
Contributor

@kpollich Might this be a side effect of some of the recent changes you made in this area?

@kpollich kpollich self-assigned this Jul 12, 2022
kpollich added a commit to kpollich/kibana that referenced this issue Jul 18, 2022
@kpollich
Fix max width in Fleet Server flyout
5860b06 
Fixes elastic#136079
@kpollich kpollich mentioned this issue Jul 18, 2022
Merged
kpollich added a commit that referenced this issue Jul 19, 2022
@kpollich
[Fleet] Fleet Server flyout fixes (#136566)
f862943 
* Go to Fleet mode when continue enrolling is selected

Fixes #136080

* Fix max width in Fleet Server flyout

Fixes #136079

* Use fleet mode when fleet server ready, standalone mode otherwise per PR feedback
kibanamachine pushed a commit that referenced this issue Jul 19, 2022
@kpollich
[Fleet] Fleet Server flyout fixes (#136566)
76f195c 
* Go to Fleet mode when continue enrolling is selected

Fixes #136080

* Fix max width in Fleet Server flyout

Fixes #136079

* Use fleet mode when fleet server ready, standalone mode otherwise per PR feedback

(cherry picked from commit f862943)
kibanamachine added a commit that referenced this issue Jul 19, 2022
@kibanamachine @kpollich
[Fleet] Fleet Server flyout fixes (#136566) (#136669)
4741a65 
* Go to Fleet mode when continue enrolling is selected

Fixes #136080

* Fix max width in Fleet Server flyout

Fixes #136079

* Use fleet mode when fleet server ready, standalone mode otherwise per PR feedback

(cherry picked from commit f862943)

Co-authored-by: Kyle Pollich <[email protected]>
@amolnater-qasource amolnater-qasource added the QA:Ready for Testing Code is merged and ready for QA to validate label Jul 21, 2022
@amolnater-qasource
Copy link
Author

Hi @kpollich
We have revalidated this issue on latest 8.4 Snapshot and found it fixed now.

  • UI doesn't get distorted with long fleet server host url under Add fleet server flyout.

Build details:
BUILD: 54789
COMMIT: af3a3cb

Screenshot:
13

Hence marking this as QA:Validated.
Thanks

@amolnater-qasource amolnater-qasource added QA:Validated Issue has been validated by QA and removed QA:Ready for Testing Code is merged and ready for QA to validate labels Jul 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kpollich kpollich

Labels
bug Fixes for quality problems that affect the customer experience impact:medium Addressing this issue will have a medium level of impact on the quality/strength of our product. QA:Validated Issue has been validated by QA Team:Fleet Team label for Observability Data Collection Fleet team
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[Fleet] Fleet Server flyout fixes kpollich/kibana
5 participants
@jen-huang @kpollich @elasticmachine @manishgupta-qasource @amolnater-qasource